This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
cc: Avoid issuing COMMANDS_COMPLETED queries unless necessary. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change to the Fence API that allows GLRenderer to not issue sync queries unless some resource that depend on them was used to produce a frame. Also includes some minor renaming cleanup related to usage of Fences in ResourceProvider code. BUG= Review URL: https://codereview.chromium.org/398543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284318 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 2981c2d)
|
Sorry, but you didn't explain why this commit needs to be cherry-picked, and you've chosen a random, wrong branch that is not currently used by any version of Crosswalk. |
|
@rakuco sorry, this cherry-pick is to fix https://crosswalk-project.org/jira/browse/XWALK-2523, I still have to full test to make sure that this cherry-pick fully works, this is not intent to be merged now. |
darktears
pushed a commit
that referenced
this pull request
Sep 17, 2014
- Some OEMs don't let us change the background, so the padding is incorrect. - Also including sizing the menu too large causes clipping. BUG=398837 Review URL: https://codereview.chromium.org/469673006 Cr-Commit-Position: refs/heads/master@{#291193} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291193 0039d316-1c4b-4281-b951-d872f2087c98 (cherry picked from commit 2b66232) Review URL: https://codereview.chromium.org/531263002 Cr-Commit-Position: refs/branch-heads/2125@{#189} Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
…putStateChanged into one." This reverts commit 2dd467c. https://codereview.chromium.org/326403002/ Conflicts: content/browser/browser_plugin/browser_plugin_guest.cc content/browser/browser_plugin/browser_plugin_guest.h content/browser/frame_host/render_widget_host_view_child_frame.cc content/browser/frame_host/render_widget_host_view_child_frame.h content/browser/frame_host/render_widget_host_view_guest.h content/browser/renderer_host/render_widget_host_impl.cc content/browser/renderer_host/render_widget_host_impl.h content/browser/renderer_host/render_widget_host_view_android.h content/browser/renderer_host/render_widget_host_view_aura.h content/browser/renderer_host/render_widget_host_view_base.h content/browser/renderer_host/render_widget_host_view_mac.h content/common/view_messages.h content/renderer/render_frame_impl.cc content/renderer/render_widget.cc content/test/test_render_view_host.h BUG=417152 TEST=None Review URL: https://codereview.chromium.org/634313007 Cr-Commit-Position: refs/heads/master@{#299646} (cherry picked from commit 3517bb6) Conflicts: content/browser/frame_host/render_widget_host_view_child_frame.h content/browser/frame_host/render_widget_host_view_guest.h content/browser/renderer_host/render_widget_host_view_android.h content/browser/renderer_host/render_widget_host_view_aura.h content/browser/renderer_host/render_widget_host_view_mac.h content/test/test_render_view_host.h Review URL: https://codereview.chromium.org/663803003 Cr-Commit-Position: refs/branch-heads/2171@{#189} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
This fixes a regression vs X11 where all touch events are missing modifier flags. BUG=450650 TEST=Open http://www.rbyers.net/eventTest.html on link, hold shift, and tap the touchscreen. Page shows "shift" on the click event line. Review URL: https://codereview.chromium.org/887743002 Cr-Commit-Position: refs/heads/master@{#313788} (cherry picked from commit ec64091) Review URL: https://codereview.chromium.org/892313002 Cr-Commit-Position: refs/branch-heads/2272@{#189} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
…ign-in. The core of this issue was the split codepath in OobeUI::OobeUI(), which checks if there is a WizardController available already, and creates an ErrorScreen if it's not. The problem is that in WizardController::CreateScreen() there is no symmetrical check that an ErrorScreen was already created, although to create a new one, it uses the same NetworkErrorView instance (which is actually an ErrorScreenHandler), so it unbinds this channel from the old ErrorScreen model thus making it unusable on three screens (Enrollment, Sing-in and App Launch Splash) if there ever was a preceding call to WizardController::CreateScreen(kErrorScreenName). This fix makes sure that we only create one ErrorScreen for the one ErrorScreenHandler that we have in OobeUI. BUG=470977 Review URL: https://codereview.chromium.org/1094103002 Cr-Commit-Position: refs/heads/master@{#325995} (cherry picked from commit ac8a005) Review URL: https://codereview.chromium.org/1094173003 Cr-Commit-Position: refs/branch-heads/2357@{#189} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
BUG=526192 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1321013004 Cr-Commit-Position: refs/heads/master@{#347565} (cherry picked from commit 0d30216) TBR=chrishtr@chromium.org,wkorman@chromium.org Review URL: https://codereview.chromium.org/1321913005 . Cr-Commit-Position: refs/branch-heads/2490@{#189} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
> Two small changes: > - Better cleanup when a process has gone away, but extractors or precursors are > still present. > - Remove an unused method. > > BUG=561105 > > Review URL: https://codereview.chromium.org/1473883002 > > Cr-Commit-Position: refs/heads/master@{#362057} (cherry picked from commit 28f0a58) TBR=tsepez@chromium.org, isherman@chromium.org BUG=563762 Review URL: https://codereview.chromium.org/1491023002 . Cr-Commit-Position: refs/branch-heads/2564@{#189} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…ase. BUG=569339,505231,520213 TEST=Keyboard typing can work well on Win/Linux/CrOS. Review URL: https://codereview.chromium.org/1620633002 Cr-Commit-Position: refs/heads/master@{#370944} (cherry picked from commit c191a57) Review URL: https://codereview.chromium.org/1648213002 . Cr-Commit-Position: refs/branch-heads/2623@{#189} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#189}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This is suspected to be the cause of null pointer crash in Android WebView when RenderProcessHostImpl::FromID unexpectedly returns null. Issue is RenderProcessHostImpl::DecrementWorkerRefCount does not check for run_renderer_in_process() like RemoveRoute. Move the check to beginning of Cleanup instead. BUG=616476 Review-Url: https://codereview.chromium.org/2029623002 Cr-Commit-Position: refs/heads/master@{#397235} (cherry picked from commit 55cb5a3) Review URL: https://codereview.chromium.org/2036743002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#189} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
TBR=dimu@chromium.org Change-Id: I3c3cb57c708c5ef48e66185c990a99e79de47fc4 Reviewed-on: https://chromium-review.googlesource.com/663679 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#189} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to the Fence API that allows GLRenderer to not
issue sync queries unless some resource that depend on them
was used to produce a frame.
Also includes some minor renaming cleanup related to usage of
Fences in ResourceProvider code.
BUG=
Review URL: https://codereview.chromium.org/398543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284318 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 2981c2d)