Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Temp] Backport r284318 from Chromium. #190

Merged

Conversation

sqliu
Copy link
Contributor

@sqliu sqliu commented Sep 18, 2014

This cherry-pick fix crash issue in Mali MP450 GPU devices.
This issue only reproduced in M37, so back-port the CL to chromium-crosswalk 37.

BUG=https://crosswalk-project.org/jira/browse/XWALK-2523

cc: Avoid issuing COMMANDS_COMPLETED queries unless necessary.

Minor change to the Fence API that allows GLRenderer to not
issue sync queries unless some resource that depend on them
was used to produce a frame.

Also includes some minor renaming cleanup related to usage of
Fences in ResourceProvider code.

BUG=

Review URL: https://codereview.chromium.org/398543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284318 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 2981c2d)

Minor change to the Fence API that allows GLRenderer to not
issue sync queries unless some resource that depend on them
was used to produce a frame.

Also includes some minor renaming cleanup related to usage of
Fences in ResourceProvider code.

BUG=

Review URL: https://codereview.chromium.org/398543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284318 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 2981c2d)
@sqliu
Copy link
Contributor Author

sqliu commented Sep 18, 2014

@wang16 @rakuco

@halton
Copy link

halton commented Sep 18, 2014

no comment on code, but I'd suggest add "[Temp] Backport r284318 from Chromium" in the git log as we did for a while.

@wang16
Copy link

wang16 commented Sep 18, 2014

Suppose 2981c2d is backport from chromium which should apply @halton 's suggestion, here it's a backport of the backport from master to M38. :)

LGTM, thanks.

@sqliu sqliu changed the title [Backport] cc: Avoid issuing COMMANDS_COMPLETED queries unless necessary. [Temp] Backport r284318 from Chromium. Sep 18, 2014
rakuco pushed a commit that referenced this pull request Sep 18, 2014
[Temp] Backport r284318 from Chromium.
@rakuco rakuco merged commit 8edfc5b into crosswalk-project:crosswalk-8/37.0.2062.120 Sep 18, 2014
@rakuco
Copy link

rakuco commented Sep 18, 2014

Thanks, please remember to roll DEPS.xwalk in crosswalk-8.

nagineni pushed a commit to nagineni/chromium-crosswalk that referenced this pull request Sep 22, 2014
Revert "Fix DesktopMediaPickerViews to handle background parent_web_contents"

This reverts commit 6debe58.

BUG=None

Review URL: https://codereview.chromium.org/534033002

Cr-Commit-Position: refs/branch-heads/2125@{crosswalk-project#190}
Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears pushed a commit that referenced this pull request Nov 17, 2014
- Create HW decoder using first codec in MediaCoedcList instead of
using createDecoderByType function. Later may result in opening
OMX.SEC.vp8.dec decoder, which can not be used for surface decoding.
- Revert r279297 and mark all OMX.SEC.* codecs as non HW accelerated.

BUG=408353, 396578
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/605883002

Cr-Commit-Position: refs/heads/master@{#297667}
(cherry picked from commit 6e86e4f)

Review URL: https://codereview.chromium.org/666953003

Cr-Commit-Position: refs/branch-heads/2171@{#190}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk pushed a commit that referenced this pull request Jan 27, 2015
BUG=436669

Review URL: https://codereview.chromium.org/760803002

Cr-Commit-Position: refs/heads/master@{#306308}
(cherry picked from commit 1a6e763)

Review URL: https://codereview.chromium.org/777523002

Cr-Commit-Position: refs/branch-heads/2214@{#190}
Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
This reverts commit b6fb515.

BUG=

Review URL: https://codereview.chromium.org/895553003

Cr-Commit-Position: refs/branch-heads/2272@{#190}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
BUG=458280

Review URL: https://codereview.chromium.org/926573002

Cr-Commit-Position: refs/heads/master@{#317889}

Review URL: https://codereview.chromium.org/989363002

Cr-Commit-Position: refs/branch-heads/2311@{#190}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 30, 2015
TBR=laforge
BUG=478079

Review URL: https://codereview.chromium.org/1096713002

Cr-Commit-Position: refs/heads/master@{#325897}
(cherry picked from commit 0987742)

Review URL: https://codereview.chromium.org/1080953005

Cr-Commit-Position: refs/branch-heads/2357@{#190}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
…rated submission rates

This allows for apples to apples comparison of generated vs. non-generated
submission success rates on the same forms.

BUG=509827

Review URL: https://codereview.chromium.org/1228783006

Cr-Commit-Position: refs/heads/master@{#345707}
(cherry picked from commit cc48d84)

Review URL: https://codereview.chromium.org/1320713006 .

Cr-Commit-Position: refs/branch-heads/2490@{#190}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
This is needed to complete the shipping of action buttons.
Seems like it was accidentally not included in #358304.

BUG=513671

Review URL: https://codereview.chromium.org/1487763003

Cr-Commit-Position: refs/heads/master@{#362414}
(cherry picked from commit ea938a3)

Review URL: https://codereview.chromium.org/1490083002 .

Cr-Commit-Position: refs/branch-heads/2564@{#190}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
* The original CL was committed but reverted due to a use-of-uninitialized-value
report: https://codereview.chromium.org/1435633002/#msg31 This CL re-commits the
original CL with a patch that initializes the member, |is_main_resource_load|,
in its containing object's constructors.

Changes from the original commit:
 - Add the member init in the initializer list of the constructors of
   ServiceWorkerFetchRequest class (in service_worker_types.cc).

--
As per the latest spec update, this CL implements FetchEvent.clientId attribute.

Spec discussion: w3c/ServiceWorker#723 (comment)
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#fetch-event-clientid

Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

The layout tests for this CL are mostly taken from Mozilla's work instead of
making new ones to ensure compatibility: https://bugzilla.mozilla.org/show_bug.cgi?id=1222464

BUG=552309

Review URL: https://codereview.chromium.org/1597383002

Cr-Commit-Position: refs/heads/master@{#370073}
(cherry picked from commit f527e86)

Review URL: https://codereview.chromium.org/1648873003 .

Cr-Commit-Position: refs/branch-heads/2623@{#190}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
This change fixes a crash in animation of -webkit-filter by always falling back
to the legacy animation code path.

BUG=592177

Review URL: https://codereview.chromium.org/1776873002

Cr-Commit-Position: refs/heads/master@{#380099}
(cherry picked from commit c22f57c)

Review URL: https://codereview.chromium.org/1782833004 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#190}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#190}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
R=dschuyler@chromium.org
TBR=hcarmona@chromium.org

(cherry picked from commit 6978123)

Bug: 763309
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5692d0e828a217e2bb38409e27c2f6b5f62a9592
Reviewed-on: https://chromium-review.googlesource.com/658493
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500785}
Reviewed-on: https://chromium-review.googlesource.com/664360
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#190}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants