This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Tizen] Make content fit to the viewport #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This actually means that 'setShrinksViewportContentToFit' setting should be set. This is necessary for viewport meta tag enabling on Tizen.
|
Testing patch series with pozdnyakov/chromium-crosswalk@b83a40a as its head.
|
|
@kenchris PTAL |
|
Is this going to be upstreamed (enabling this on Linux)? Is there an associated JIRA ticket? |
|
@rakuco unfortunately no upstream perspective |
|
@rakuco JIRA XWALK-2577 ticket is closed with a temporary solution (disabling viewport-meta) |
|
Shouldn't you reference this ticket in your commit/PR messages then? Or is this only tangentially related? |
|
I don't think I should, this is related but does not fix the issue (failing apps) alone. The change is needed to render pages like http://people.opera.com/andreasb/viewport/ex01.html |
|
OK. I'm asking for accountability issues. Merging then. |
rakuco
pushed a commit
that referenced
this pull request
Sep 25, 2014
[Tizen] Make content fit to the viewport
|
Don't forget you need to roll |
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
…dth + Margin tweaks for better fit on landscape mode. BUG=418546,419018 Review URL: https://codereview.chromium.org/618283002 (cherry picked from commit b90a203) Cr-Original-Commit-Position: refs/heads/master@{#297661} Cr-Commit-Position: refs/branch-heads/2171@{#192} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk
pushed a commit
that referenced
this pull request
Jan 27, 2015
The previous string was wrong, as it was saying about enabling, which is opposite to what that flag does. TBR=hirono@chromium.org TEST=Tested manually in chrome://flags. BUG=436732 Review URL: https://codereview.chromium.org/756383002 Cr-Commit-Position: refs/heads/master@{#305793} (cherry picked from commit 89b6e5e) Review URL: https://codereview.chromium.org/779553002 Cr-Commit-Position: refs/branch-heads/2214@{#192} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
…tiple Prefix Matches Work This code significantly simplies the logic for matching. Indeed, the old logic was buggy because multiple prefix matches could results in explosive growth of the list of matches (even if only one bookmark matches). Reviewer, I would avoid reading and trying to understand what CombineMatches() and the code that calls it is currently broken. See the second test case I added. Before this change, that test never terminates (in the time I waited) and explodes the machine's memory. Luckily this was rare; there are few reports on crbug. It's possible this new code is slower or faster than before (when the old code behaved correctly). I plan to look at the Omnibox.Providertime.Bookmarks numbers before and after this change. TBR= sky for owners stamp; review it if you feel like BUG=450850,434604 Review URL: https://codereview.chromium.org/882823004 Cr-Commit-Position: refs/heads/master@{#313574} (cherry picked from commit 02f304b) Review URL: https://codereview.chromium.org/878413004 Cr-Commit-Position: refs/branch-heads/2272@{#192} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
The image buffer may not contain all bytes in the last row, causing an exception. Fix by only reading up to what's remaining() in the buffer. BUG=458701 Review URL: https://codereview.chromium.org/975913003 Cr-Commit-Position: refs/heads/master@{#319401} (cherry picked from commit e64698b) TBR=mcasas@chromium.org Review URL: https://codereview.chromium.org/990903004 Cr-Commit-Position: refs/branch-heads/2311@{#192} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
…licies. TBR=tnagel@chromium.org BUG=451073 Review URL: https://codereview.chromium.org/1076323003 Cr-Commit-Position: refs/branch-heads/2357@{#192} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
…s bubble." to 2490. > The parent view of the button was too small, and the button lay outside the > bounds of its parent view. Increasing the size of its parent view fixed the > problem. > > BUG=525544 > > Review URL: https://codereview.chromium.org/1312163006 > > Cr-Commit-Position: refs/heads/master@{#347549} BUG=525544 TBR=andresantoso@chromium.org, groby@chromium.org Review URL: https://codereview.chromium.org/1328673004 . Cr-Commit-Position: refs/branch-heads/2490@{#192} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…nfobar. There is no good explanation of the crash: 1. When clicking on a dangerous download, we set mPendingRequest and start the infobar. 2. When user dismiss the infobar, we reset mPendingRequest. 3. If mPendingRequest is non null, a 2nd request will not trigger any infobar. So at anytime, there are at most 1 dangerous infobar. And if mPendingRequest is non null, there should be an infobar showing, vice versa. So this a speculative fix to the crash from the crash stack we have seen. TBR=dtrainor BUG=579707 Review URL: https://codereview.chromium.org/1614453003 Cr-Commit-Position: refs/heads/master@{#372153} (cherry picked from commit 7efc4d5) Review URL: https://codereview.chromium.org/1646353002 . Cr-Commit-Position: refs/branch-heads/2623@{#192} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
…uched up FRE. This is a CL combining http://crrev.com/1727363003 and http://crrev.com/1698043006 which were reverted. It will be committed alongside https://chrome-internal-review.googlesource.com/#/c/249885/ which updates SigninTest to account for this CL. BUG=557781,557786 Review URL: https://codereview.chromium.org/1754903002 Cr-Commit-Position: refs/heads/master@{#380123} (cherry picked from commit 87e5f5c) TBR=newt@chromium.org NOPRESUBMIT=true NOTRY=true Review URL: https://codereview.chromium.org/1786073002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#192} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This CL makes setConnectTimeout to fail silently so we don't crash applications when this method is called. The goal of Cronet's HttpURLConnection impl is to facilitate applications to try out Cronet. In order to do so, we would like it to be as easy as possible to drop in Cronet's HttpURLConnection impl without hitting any exceptions. We should only reserve the use of exceptions when absolutely necessary (e.g. in matters of correctness), but not for issues of sub-optimality (e.g. HTTP cache being ignored). BUG=611851 TBR=pauljensen@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2030933002 Cr-Commit-Position: refs/heads/master@{#397450} (cherry picked from commit 7130ccb) Review-Url: https://codereview.chromium.org/2037683003 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#192} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
There are several steps of the Bluetooth connection flow which call into Bluetooth APIs and wait for an asynchronous response. These asynchronous callbacks *should* be getting invoked in a timely manner by Bluetooth, but this is not happening in practice. This CL adds timeouts for each step of the connection process in which we wait for an asynchronous reply. TBR=khorimoto@google.com (cherry picked from commit b3e3134) Bug: 763176, 672263 Change-Id: Ia7a538e0de8280346a3c113c7dccd5c18cc7086d Reviewed-on: https://chromium-review.googlesource.com/657811 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Tim Song <tengs@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501418} Reviewed-on: https://chromium-review.googlesource.com/664181 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#192} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually means that 'setShrinksViewportContentToFit'
setting should be set. This is necessary for viewport
meta tag enabling on Tizen.