This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Temp] Apply ozone-wayland's 0008-Fix-crash-when-switching-to-console-VT-mode.patch. #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-VT-mode.patch. Original commit message: Fix crash when switching to console(VT) mode Buffer swapping should not be synchronized so that the GPU process is not blocked by waiting for a frame update from Weston. Bug: TC-341 It is not clear from ozone-wayland's pull request #300 if this change has been submitted upstream.
|
Testing patch series with rakuco/chromium-crosswalk@c1470fd as its head.
|
|
LGTM |
rakuco
pushed a commit
that referenced
this pull request
Oct 2, 2014
[Temp] Apply ozone-wayland's 0008-Fix-crash-when-switching-to-console-VT-mode.patch.
darktears
pushed a commit
that referenced
this pull request
Nov 17, 2014
Restore the previous behavior of hiding the PopupWindow-based text selection handles on scroll. Note that such hiding applies when the content is scrolling as well as when the containing View is moving. Also avoid sync barrier issues by deferring invalidations relating to visibility and position updates of the PopupWindow. BUG=423120 Review URL: https://codereview.chromium.org/657593003 Cr-Commit-Position: refs/heads/master@{#300114} (cherry picked from commit 4a73ea3) TBR=jdduke@chromium.org Review URL: https://codereview.chromium.org/663173002 Cr-Commit-Position: refs/branch-heads/2171@{#194} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk
pushed a commit
that referenced
this pull request
Jan 27, 2015
BUG=427442 TBR=rogerta@chromium.org Review URL: https://codereview.chromium.org/730163003 Cr-Commit-Position: refs/heads/master@{#304633} (cherry picked from commit 0cce230) Review URL: https://codereview.chromium.org/755923005 Cr-Commit-Position: refs/branch-heads/2214@{#194} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
pushed a commit
that referenced
this pull request
Feb 27, 2015
In document mode, we used to start loading the web contents of a newly opened tab before the chrome tab object is ready. This would result in chrome intercept delegate not being initialized in time to figure out whether the loaded URL needs to be sent as an intent instead. This changes the order of operations to create the chrome tab first with the given web contents and only then initiate the load. BUG=432562 TBR=tedchoc@chromium.org,jbudorick@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/883153002 Cr-Commit-Position: refs/heads/master@{#313966} (cherry picked from commit 4c55f39) Review URL: https://codereview.chromium.org/896633003 Cr-Commit-Position: refs/branch-heads/2272@{#194} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
Ensure embedded cookies get deleted even when no other local data is present. BUG=459719 Review URL: https://codereview.chromium.org/994593002 Cr-Commit-Position: refs/heads/master@{#319732} TBR=newt NOTRY=true Review URL: https://codereview.chromium.org/982173003 Cr-Commit-Position: refs/branch-heads/2311@{#194} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
BUG=472269 TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/1055263005 Cr-Commit-Position: refs/heads/master@{#325356} (cherry picked from commit 9bd9ab4) Review URL: https://codereview.chromium.org/1103573002 Cr-Commit-Position: refs/branch-heads/2357@{#194} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
BUG=529225 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/1330833003 Cr-Commit-Position: refs/heads/master@{#347804} (cherry picked from commit 7eaa8af) Review URL: https://codereview.chromium.org/1325653005 . Cr-Commit-Position: refs/branch-heads/2490@{#194} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
> The test OmniboxPopupViewMacTest was crashing because of an invalid pointer > dereference. The root cause was that a base::scoped_nsobject member was captured > as an implicit parameter to an Obj-C block, which makes a raw copy of the |this| > pointer. I changed the captured parameter to be an Obj-C object, which > automatically gets retained/released. > > BUG=551007, 560482 > > Review URL: https://codereview.chromium.org/1466333004 > > Cr-Commit-Position: refs/heads/master@{#362184} (cherry picked from commit 36c234e) TBR=mark@chromium.org BUG=560482 Review URL: https://codereview.chromium.org/1486393002 . Cr-Commit-Position: refs/branch-heads/2564@{#194} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…rects. BUG=581264 Review URL: https://codereview.chromium.org/1640363003 Cr-Commit-Position: refs/heads/master@{#372117} (cherry picked from commit 1124965) Review URL: https://codereview.chromium.org/1648953003 . Cr-Commit-Position: refs/branch-heads/2623@{#194} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
This CL fixes a bug where GLSurfaceOzoneSurfaceless was not calling SurfaceOzoneEGL::GetEGLSurfaceConfig(). Instead, the default implementation in GLSurfaceEGL::GetConfig() would be used to pick an EGL config. This resulted in "No suitable EGL configs found." being logged everytime a GLSurfaceOzoneSurfaceless was created. Instead it now calls SurfaceOzoneEGL::GetEGLSurfaceConfig(). For offscreen surfaces SurfacelessEGL is used. This produced the same error message on creation. SurfaceOzoneEGL::GetEGLSurfaceConfig() can't be used with offscren surfaces as there is no window associated with the offscreen surface. Instead, the EGL_SURFACE_TYPE attribute is set to EGL_DONT_CARE in GLSurfaceEGL::GetConfig() for surfaceless surfaces. The bug doesn't seem to cause problems beyond the logged error messages as drawing still works under Ozone. BUG=591064 Review URL: https://codereview.chromium.org/1738973004 Cr-Commit-Position: refs/heads/master@{#380171} (cherry picked from commit 445089a) Review URL: https://codereview.chromium.org/1788713003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#194} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Having the Document's MainThreadTaskRunner on the Oilpan heap is preferable for three reasons: - Correctly accounts for the MainThreadTaskRunner::m_context back reference, by having it be traced Member<>. - The MainThreadTaskRunner must not perform tasks when it (and the Document) is in the process of being swept. By having the posted tasks keep a weak persistent reference to MainThreadTaskRunner, the Oilpan GC will ensure that the weak references will be cleared once MainThreadTaskRunner has been deemed garbage. - Similarly for the timer-initiated running of a MainThreadTaskRunner's pending tasks. The Timer<> abstraction takes care of not firing a timer if its owner is an Oilpan heap object that's about to be swept. But it is not without downsides: - A CrossThreadWeakPersistent<> has to be created for every task closure posted to the main thread, and copying that persistent reference around while creating the closure, something that is not without overhead. - Threads not attached to Oilpan needing to post tasks to the main thread will have to create these persistents also. Having that happen when a GC is in progress is hard to support, as it risks introducing and removing persistent heap references in ways that interfere with the GC processing the heap. The latter point is sufficient reason not to require the allocation of CrossThreadWeakPersistent<>s when posting main thread tasks, hence MainThreadTaskRunner is moved off the Oilpan heap. By doing so, the benefits above that the Oilpan GC infrastructure provided "for free" have to be taken care of manually. C'est la vie. R= BUG=610477 Review-Url: https://codereview.chromium.org/1938313003 Cr-Commit-Position: refs/heads/master@{#396432} (cherry picked from commit 93ddd5f) Review URL: https://codereview.chromium.org/2034713003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#194} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This makes a minimal set up changes to get the supervised user creation screen to support the new set of default user images. The changes are: - Limit default images to 23 first images of current set. - Increase size of image grid to 272px to be able to display 23 images. - Always scale default image to 220x220px. - Use 576x576 capture size to match settings UI. - Disable animation for grid images. - Always use 2x resource for preview. Limiting the number of default images to 23 avoids more complicated changes needed to support proper overflow handling for the grid. This can be improved as part of more general UI updates to the supervised user creation flow. TBR=reveman@chromium.org (cherry picked from commit 802456f) Bug: 763780, 763777, 763776 Test: manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I64346ee6baa8dedb1b3acc8d738716c96f6aa0d7 Reviewed-on: https://chromium-review.googlesource.com/661862 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501150} Reviewed-on: https://chromium-review.googlesource.com/663306 Reviewed-by: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#194} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fix crash when switching to console(VT) mode
Buffer swapping should not be synchronized so that the GPU process
is not blocked by waiting for a frame update from Weston.
Bug: TC-341
It is not clear from ozone-wayland's pull request #300 if this change
has been submitted upstream.