Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

.gitignore: Ignore src/third_party/webcl. #196

Merged
merged 1 commit into from
Oct 8, 2014

Conversation

junmin-zhu
Copy link
Contributor

We started checking out this directory with Crosswalk including the
webcl conformance test suite. So we should ignore this directory
to avoid being removed when gclient sync.

@crosswalk-trybot
Copy link

Testing patch series with junmin-zhu/chromium-crosswalk@366baab as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/125)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/123)

@junmin-zhu
Copy link
Contributor Author

@huningxin @rakuco , could you please help to review the patch? thanks

@rakuco
Copy link

rakuco commented Oct 8, 2014

Almost OK, you just need to keep the list there alphabetically sorted.

@crosswalk-trybot
Copy link

Testing patch series with junmin-zhu/chromium-crosswalk@d8b4494 as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/126)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/124)

@junmin-zhu
Copy link
Contributor Author

@rakuco , done. Thanks.

We started checking out this directory with Crosswalk including the
webcl conformance test suite. So we should ignore this directory
to avoid being removed when gclient sync.
rakuco pushed a commit that referenced this pull request Oct 8, 2014
.gitignore: Ignore src/third_party/webcl.
@rakuco rakuco merged commit b7e4b6e into crosswalk-project:master Oct 8, 2014
darktears pushed a commit that referenced this pull request Nov 17, 2014
BUG=340882

Review URL: https://codereview.chromium.org/648333002

Cr-Commit-Position: refs/heads/master@{#299364}
(cherry picked from commit 093e4d5)

Review URL: https://codereview.chromium.org/665123005

Cr-Commit-Position: refs/branch-heads/2171@{#196}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk pushed a commit that referenced this pull request Jan 27, 2015
We should deprecate RequestUsbAccess because the parameters may be
ambiguious.

BUG=436259
TEST=trybot and manual testing on panther.
TBR=reillyg@chromium.org

Review URL: https://codereview.chromium.org/769973003

Cr-Commit-Position: refs/heads/master@{#306439}
(cherry picked from commit 43d512b)

Review URL: https://codereview.chromium.org/779703002

Cr-Commit-Position: refs/branch-heads/2214@{#196}
Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
This part is needed for the cherry-pick of
https://code.google.com/p/chromium/issues/detail?id=432562 to work.

BUG=432562
R=dtrainor@chromium.org

Review URL: https://codereview.chromium.org/895833002

Cr-Commit-Position: refs/branch-heads/2272@{#196}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
BUG=464030
TBR=amineer@chromium.org,mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/995753004

Cr-Commit-Position: refs/branch-heads/2311@{#196}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 30, 2015
DelegatedRendererLayerImpl will claim ownership of resources in a frame,
and this makes unused resources from the previous frame be returned to
the child.

However, this was being done on the pending tree, but the previous frame
was still in the active tree and its resources would be returned early.
Instead, delay telling the ResourceProvider about the frame's resources
until the frame replaces the resources on the active tree.

TBR=enne, piman@chromium.org
BUG=475894

Review URL: https://codereview.chromium.org/1087843006

Cr-Commit-Position: refs/heads/master@{#325927}
(cherry picked from commit b435e7a)

Review URL: https://codereview.chromium.org/1094453005

Cr-Commit-Position: refs/branch-heads/2357@{#196}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
…set & CommitText.

BUG=522782
TEST=Verified the bug not repro on local sandbox.

Review URL: https://codereview.chromium.org/1307783003

Cr-Commit-Position: refs/heads/master@{#345554}
(cherry picked from commit 952eb74)

Review URL: https://codereview.chromium.org/1320573004 .

Cr-Commit-Position: refs/branch-heads/2490@{#196}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
Undo is a per-activity setting, not a per-device setting. Therefore it
is not appropriate to let DeviceClassManager singleton to handle whether
undo is allowed.

Also it turns out that as long as TabModelImpl is only used in
ChromeTabbedActivity, undo is always going to to be enabled, so there is
no point that ENABLE_HIGH_END_UI_UNDO should exist.

BUG=555500

Review URL: https://codereview.chromium.org/1460573002

Cr-Commit-Position: refs/heads/master@{#360495}
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/1489313002 .

Cr-Commit-Position: refs/branch-heads/2564@{#196}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
… becomes primary.

BUG=580754

Review URL: https://codereview.chromium.org/1631023002

Cr-Commit-Position: refs/heads/master@{#371566}
(cherry picked from commit 3c2d523)

Review URL: https://codereview.chromium.org/1649063002 .

Cr-Commit-Position: refs/branch-heads/2623@{#196}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
…ertest

BUG=594114

Review URL: https://codereview.chromium.org/1784343003

Cr-Commit-Position: refs/heads/master@{#380719}
(cherry picked from commit 57532c0)

Review URL: https://codereview.chromium.org/1790523003 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#196}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
Allocating & releasing a CrossThread(Weak)Persistent is something that
all threads are currently allowed, even those not attached to Oilpan and
having no heap of their own. It is however not safe for the set of
CrossThreadPersistents to be altered while a garbage collection is
underway.

Not just while the set of registered persistents are being marked and
traced, but up until and including the processing of weak (persistent)
references that happen after marking. If not, a thread would be able to
release a CrossThreadWeakPersistent node which the weak processing separately
maintains a pointer to, clearing & freeing its allocation. Which would
cause havoc, hence we impose a lock on CrossThreadPersistentRegion while
the marking and global weak processing is being performed -- any thread
attempting to create or free cross-thread persistents will be locked out
for the duration.

Following r396432, the use of CrossThreadPersistents from non-attached threads
has been reduced greatly and is slight.

R=
BUG=610477

Review-Url: https://codereview.chromium.org/2013173002
Cr-Commit-Position: refs/heads/master@{#396540}
(cherry picked from commit 174054b)

Review URL: https://codereview.chromium.org/2033893002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#196}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
OkHttp crashes due to undiscovered threading issues, this is especially
bad in Android O. See CL for more context:
https://chromium-review.googlesource.com/c/chromium/src/+/616272

BUG=753302
TBR=wnwen@chromium.org

(cherry picked from commit c2282f0)

Change-Id: Ic2e166b38222ad3c2001bee681060f47a700c1ed
Reviewed-on: https://chromium-review.googlesource.com/660799
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500960}
Reviewed-on: https://chromium-review.googlesource.com/664918
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#196}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants