-
Notifications
You must be signed in to change notification settings - Fork 211
Support Crosswalk and Android System WebView in the same application #402
base: master
Are you sure you want to change the base?
Conversation
xwalk will put icudtl.dat in different folder like raw/res instead of assets.So it's not right to check and read from assets/icudtl.dat in high priority.Otherwise when android webview is called , app will extract webview.apk and copy it's icudtl.dat to assets,hence the two icudtl.dat will conflict. BUG=XWALK-7004
Testing patch series with dlmu2001/chromium-crosswalk@f0b35e0 as its head.
|
LGTM |
@lincsoon is it OK to merge this? @fujunwei gave his OK |
He's now @sunlin-link FWIW |
@rakuco thanks, actually I should have asked you since this is chromium-crosswalk |
I think this needs some more work, as well as review from the Android people. For one, I'm not sure if we've ever tested or explicitly supported apps mixing the stock WebView with Crosswalk. Second, we also need to make sure this doesn't break apps using only Crosswalk. With that in mind, I wonder if there's anything to fix on the Crosswalk side to avoid changing chromium-crosswalk, and, lastly, just like Chromium we don't leave dead, commented out code in the tree, so if that's the path we want to go that code needs to be removed, not commented out. @sunlin-link: ping again |
Xwalk put icudtl.dat in different folder like raw/res instead of assets now. It's not reasonable to check and read from assets folder. It's obvious and will not break apps using only Crosswalk. By the way, the process is so long now. I guess this problem will hang for long time in your suggestion. |
It's March 9th now and please take a merge - it's impeding our release, considering that we cannot use |
This test was already disabled on iOS 11 iPad, but it has started failing on iPhone as well in the iOS 11 GM build. BUG=753098 Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83 Reviewed-on: https://chromium-review.googlesource.com/664837 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#501604}(cherry picked from commit 9ca5963) Reviewed-on: https://chromium-review.googlesource.com/679294 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#402} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
xwalk will put icudtl.dat in different folder like raw/res instead of
assets.So it's not right to check and read from assets/icudtl.dat in
high priority.Otherwise when android webview is called , app will
extract webview.apk and copy it's icudtl.dat to assets,hence the two
icudtl.dat will conflict.
BUG=XWALK-7004