Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Support Crosswalk and Android System WebView in the same application #402

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dlmu2001
Copy link

@dlmu2001 dlmu2001 commented Dec 9, 2016

xwalk will put icudtl.dat in different folder like raw/res instead of
assets.So it's not right to check and read from assets/icudtl.dat in
high priority.Otherwise when android webview is called , app will
extract webview.apk and copy it's icudtl.dat to assets,hence the two
icudtl.dat will conflict.

BUG=XWALK-7004

xwalk will put icudtl.dat in different folder like raw/res instead of
assets.So it's not right to check and read from assets/icudtl.dat in
high priority.Otherwise when android webview is called , app will
extract webview.apk and copy it's icudtl.dat to assets,hence the two
icudtl.dat will conflict.

BUG=XWALK-7004
@crosswalk-trybot
Copy link

crosswalk-trybot commented Dec 9, 2016

Testing patch series with dlmu2001/chromium-crosswalk@f0b35e0 as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/360)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/363)

@fujunwei
Copy link

LGTM

@dlmu2001
Copy link
Author

@lincsoon @baleboy @rakuco

New thread here, 401 has been closed.

@baleboy
Copy link

baleboy commented Dec 27, 2016

@lincsoon is it OK to merge this? @fujunwei gave his OK

@rakuco
Copy link

rakuco commented Dec 30, 2016

He's now @sunlin-link FWIW

@baleboy
Copy link

baleboy commented Dec 30, 2016

@rakuco thanks, actually I should have asked you since this is chromium-crosswalk

@rakuco
Copy link

rakuco commented Jan 2, 2017

I think this needs some more work, as well as review from the Android people.

For one, I'm not sure if we've ever tested or explicitly supported apps mixing the stock WebView with Crosswalk. Second, we also need to make sure this doesn't break apps using only Crosswalk.

With that in mind, I wonder if there's anything to fix on the Crosswalk side to avoid changing chromium-crosswalk, and, lastly, just like Chromium we don't leave dead, commented out code in the tree, so if that's the path we want to go that code needs to be removed, not commented out.

@sunlin-link: ping again

@dlmu2001
Copy link
Author

dlmu2001 commented Jan 3, 2017

@rakuco

Xwalk put icudtl.dat in different folder like raw/res instead of assets now. It's not reasonable to check and read from assets folder. It's obvious and will not break apps using only Crosswalk.

By the way, the process is so long now. I guess this problem will hang for long time in your suggestion.

@zhanghai
Copy link

zhanghai commented Mar 9, 2017

It's March 9th now and please take a merge - it's impeding our release, considering that we cannot use XWalkView in an Android Service so we have to use WebView.

imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
This test was already disabled on iOS 11 iPad, but it has started failing on
iPhone as well in the iOS 11 GM build.

BUG=753098

Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83
Reviewed-on: https://chromium-review.googlesource.com/664837
Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501604}(cherry picked from commit 9ca5963)
Reviewed-on: https://chromium-review.googlesource.com/679294
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#402}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants