This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[IDL generator] Fix the #include path generation when source_file_dir… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@halton , PTAL. Thanks! |
|
The code is same as upstream code, I'm curious how this bug get triggered? Of coz, I'm okay to merge this PR and do the upstream at the same time. |
|
My understanding is our usage of the idl_generator, e.g. directory structure, triggers this. |
halton
pushed a commit
that referenced
this pull request
Sep 9, 2015
[IDL generator] Fix the #include path generation when source_file_dir…
|
Let's merge it for now and I'll report a bug to track in future. |
|
Thanks for doing that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… is empty