This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Revert "XDK Heap Profiler collector and XDK CPUProfiler" #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6e8bb75. This commit as-is breaks the M51 standalone build: ``` ../test/cctest/test-cpu-profiler.cc:1626:29: error: no viable conversion from 'const std::vector<const v8::CpuProfileNode *>' to 'const v8::CpuProfileNode *' const v8::CpuProfileNode* start_node = GetChild(env, root, "start"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../test/cctest/test-cpu-profiler.cc:1628:29: error: no viable conversion from 'const std::vector<const v8::CpuProfileNode *>' to 'const v8::CpuProfileNode *' const v8::CpuProfileNode* level2_node = GetChild(env, level1_node, "level2"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../test/cctest/test-profile-generator.cc:291:8: error: no matching member function for call to 'AddPathFromEnd' tree.AddPathFromEnd(path_vec); ~~~~~^~~~~~~~~~~~~~ .././src/profiler/profile-generator.h:215:16: note: candidate function not viable: no known conversion from 'Vector<i::StackEntry>' to 'const std::vector<StackEntry>' for 1st argument ProfileNode* AddPathFromEnd( ^ .././src/profiler/profile-generator.h:221:16: note: candidate function not viable: no known conversion from 'Vector<i::StackEntry>' to 'const std::vector<CodeEntry *>' for 1st argument ProfileNode* AddPathFromEnd( ^ ../test/cctest/test-profile-generator.cc:324:8: error: no matching member function for call to 'AddPathFromEnd' tree.AddPathFromEnd(path_vec2); ~~~~~^~~~~~~~~~~~~~ .././src/profiler/profile-generator.h:215:16: note: candidate function not viable: no known conversion from 'Vector<i::StackEntry>' to 'const std::vector<StackEntry>' for 1st argument ProfileNode* AddPathFromEnd( ^ .././src/profiler/profile-generator.h:221:16: note: candidate function not viable: no known conversion from 'Vector<i::StackEntry>' to 'const std::vector<CodeEntry *>' for 1st argument ProfileNode* AddPathFromEnd( ^ ```
|
Testing patch series with rakuco/v8-crosswalk@e236921 as its head.
|
|
Testing patch series with rakuco/v8-crosswalk@9933ba6 as its head.
|
The presubmit hooks fail even though the original upstream files are not compliant. Run `git-cl format v8` to make the coding style checks pass. This commit was not squashed into e236921 (Revert "XDK Heap Profiler collector and XDK CPUProfiler") to make it easier for future rebases to skip this change if necessary.
rakuco
force-pushed
the
fix-standalone-build
branch
from
9933ba6 to
4e54260
Compare
|
Testing patch series with rakuco/v8-crosswalk@4e54260 as its head.
|
|
@mrunalk: the standalone V8 build has been broken for almost a week since you pushed the M51 V8, and it looks like you were not watching the bots once you pushed the rebased master. To clarify: you should first push v8-crosswalk and chromium-crosswalk and only proceed with Crosswalk itself once you verify the forks are building correctly. |
|
rs+ |
|
@rakuco, It cannot be a week as I pushed M51 last Wednesday. :) I typically don't watch V8 bots as it's usually taken care of by SIMD folks, since there were no major changes to SIMD or XDK this time that somehow slipped through my mind. I will add that to my checklist from now on. Thanks for taking care of it. |
Er, sorry, I looked at the wrong dates. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6e8bb75.
This commit as-is breaks the M51 standalone build: