Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Buff Out A Few Rough Spots #2957

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

phroggster
Copy link
Collaborator

@phroggster phroggster commented Jan 7, 2025

Mystery Bag Of Trivialities

  • Adjust some bitwise ands (&) to boolean ands (&&) in games.
    • In these instances though, bitwise was probably close enough.
    • Boolean logic is clearly intended however, so let's explicitly use that.
  • Fix a Func<bool> type to be Func<boolean>.
  • Adjust one absolute path import to a relative path import.
    • VSCode at least treats the import as a first-class passenger again,
    • When it was previously crammed into the cargo hold.

Applicable Issues

None

Testing

Yes.

Screenshots

N/A

- Adjust some bitwise ands (&) to boolean ands (&&) in games.
  - In these instances though, bitwise was probably close enough.
  - Boolean logic is clearly intended, however, so let's use that.
- Fix a `Function<bool>` type to be `Function<boolean>`.
- Adjust one absolute path import to a relative path import.
  - VSCode at least treats the import as a first-class passenger again,
  - When it was previously crammed into the cargo hold.
@phroggster phroggster requested a review from ebiggz as a code owner January 7, 2025 10:04
@zunderscore zunderscore merged commit 30c4683 into crowbartools:v5 Jan 8, 2025
1 check passed
@phroggster phroggster deleted the mystery-bag branch January 9, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants