DO NOT MERGE: Major code rework #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngunia
reviewed
Jan 21, 2020
| def sanitize_fields(self): | ||
| fields = [ "center", "link1", "link2", "link3", "link4", "link5", "link6" ] | ||
| for field in fields: | ||
| self.__setattr__(field, self.__getattribute__(field).upper()) |
There was a problem hiding this comment.
I had a discussion with someone in #bug-reports that they found two transcriptions for separate images, with the same transcription, but different hashes.
I was not able to reproduce the hashes (and the no hash bug was found at this time, and more pressing) but my only guess is that there were extra white spaces in the center and/or link fields. I see that you've limited the field sizes appropriately to 1/7, but I'd suggest append .strip() to the field sanitation to prevent rejecting possibly valid transcriptions but just with extra spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is work in progress and I just created it to let everyone know I'm on this. Have a look at the commits if you like.