Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting source files with 'dest' param for 'download sources', … #399

Merged
merged 5 commits into from
Oct 27, 2021

Conversation

frombetelgeuse
Copy link
Contributor

…'dryrun translations' and 'download' commands

…'dryrun translations' and 'download' commands
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #399 (b3b7e6e) into cli3 (e49d6a7) will increase coverage by 1.29%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #399      +/-   ##
============================================
+ Coverage     56.84%   58.12%   +1.29%     
- Complexity      930      960      +30     
============================================
  Files           153      153              
  Lines          4568     4601      +33     
  Branches        683      704      +21     
============================================
+ Hits           2596     2674      +78     
+ Misses         1651     1601      -50     
- Partials        321      326       +5     
Impacted Files Coverage Δ
...m/crowdin/cli/commands/actions/DownloadAction.java 75.72% <0.00%> (-0.27%) ⬇️
...cli/commands/functionality/DryrunTranslations.java 74.36% <0.00%> (-1.95%) ⬇️
...owdin/cli/commands/functionality/SourcesUtils.java 89.29% <80.00%> (-2.71%) ⬇️
...in/cli/commands/actions/DownloadSourcesAction.java 81.71% <84.62%> (+81.71%) ⬆️
...din/cli/commands/picocli/StringListSubcommand.java 100.00% <0.00%> (ø)
.../cli/commands/functionality/TranslationsUtils.java 79.32% <0.00%> (+6.90%) ⬆️
...crowdin/cli/commands/actions/StringListAction.java 88.24% <0.00%> (+11.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49d6a7...b3b7e6e. Read the comment docs.

@andrii-bodnar andrii-bodnar mentioned this pull request Oct 7, 2021
@andrii-bodnar andrii-bodnar merged commit 6f479a2 into cli3 Oct 27, 2021
@andrii-bodnar andrii-bodnar deleted the fix-dest branch October 27, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants