Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #406

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Improvements #406

merged 3 commits into from
Nov 19, 2021

Conversation

frombetelgeuse
Copy link
Contributor

  • Add check if an archive is empty and add a message when there are no files to the 'download' command
  • Fix '%original_path%' placeholder for downloading
  • Improve timing for checking building translations

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #406 (143f0c1) into cli3 (2a1d5cf) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #406      +/-   ##
============================================
+ Coverage     57.81%   57.81%   +0.01%     
- Complexity      951      953       +2     
============================================
  Files           153      153              
  Lines          4581     4593      +12     
  Branches        696      698       +2     
============================================
+ Hits           2648     2655       +7     
- Misses         1605     1609       +4     
- Partials        328      329       +1     
Impacted Files Coverage Δ
...om/crowdin/cli/commands/functionality/FsFiles.java 2.71% <0.00%> (-0.32%) ⬇️
...m/crowdin/cli/commands/actions/DownloadAction.java 75.79% <83.34%> (+0.08%) ⬆️
src/main/java/com/crowdin/cli/BaseCli.java 94.74% <100.00%> (+0.99%) ⬆️
...in/java/com/crowdin/cli/utils/PlaceholderUtil.java 80.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1d5cf...143f0c1. Read the comment docs.

@andrii-bodnar andrii-bodnar merged commit ac91d43 into cli3 Nov 19, 2021
@andrii-bodnar andrii-bodnar deleted the improvements branch November 19, 2021 08:09
@andrii-bodnar andrii-bodnar mentioned this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to extract files. Try to run the application with admin permission
2 participants