Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating test coverage #500

Merged
merged 5 commits into from
Nov 7, 2022
Merged

updating test coverage #500

merged 5 commits into from
Nov 7, 2022

Conversation

calfaand
Copy link
Contributor

@calfaand calfaand commented Nov 6, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #500 (5ace7bf) into cli3 (b396eba) will increase coverage by 1.68%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               cli3     #500      +/-   ##
============================================
+ Coverage     56.93%   58.61%   +1.68%     
- Complexity      984     1010      +26     
============================================
  Files           153      153              
  Lines          4771     4771              
  Branches        737      737              
============================================
+ Hits           2716     2796      +80     
+ Misses         1687     1576     -111     
- Partials        368      399      +31     
Impacted Files Coverage Δ
.../java/com/crowdin/cli/properties/SettingsBean.java 63.64% <0.00%> (ø)
.../com/crowdin/cli/properties/PropertiesBuilder.java 53.79% <0.00%> (+1.69%) ⬆️
...ava/com/crowdin/cli/properties/BaseProperties.java 59.19% <0.00%> (+4.09%) ⬆️
...in/java/com/crowdin/cli/properties/TargetBean.java 18.58% <0.00%> (+18.58%) ⬆️
...com/crowdin/cli/properties/PropertiesBuilders.java 48.49% <0.00%> (+21.22%) ⬆️
...owdin/cli/properties/ProjectPropertiesBuilder.java 31.92% <0.00%> (+31.92%) ⬆️
.../com/crowdin/cli/properties/ParamsWithTargets.java 33.34% <0.00%> (+33.34%) ⬆️
...n/cli/properties/PropertiesWithTargetsBuilder.java 36.21% <0.00%> (+36.21%) ⬆️
.../crowdin/cli/properties/PropertiesWithTargets.java 86.37% <0.00%> (+77.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar
Copy link
Member

@calfaand thanks a lot for your contribution! 🚀

Just left some comments, please take a look

@calfaand
Copy link
Contributor Author

calfaand commented Nov 7, 2022

@andrii-bodnar I made changes you requested.

@andrii-bodnar
Copy link
Member

@calfaand thank you!

Please check a couple of new comments

@calfaand
Copy link
Contributor Author

calfaand commented Nov 7, 2022

@andrii-bodnar what about now ?

@andrii-bodnar
Copy link
Member

@calfaand looks good now in general, added some minor comments related to code formatting 🙂

@calfaand
Copy link
Contributor Author

calfaand commented Nov 7, 2022

@andrii-bodnar formatted the code

@andrii-bodnar
Copy link
Member

@calfaand looks good to me, thanks for the contribution!

@andrii-bodnar andrii-bodnar merged commit 6250bd3 into crowdin:cli3 Nov 7, 2022
@andrii-bodnar andrii-bodnar linked an issue Nov 7, 2022 that may be closed by this pull request
6 tasks
@andrii-bodnar andrii-bodnar mentioned this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests coverage for properties helpers
2 participants