-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating test coverage #500
Conversation
Codecov Report
@@ Coverage Diff @@
## cli3 #500 +/- ##
============================================
+ Coverage 56.93% 58.61% +1.68%
- Complexity 984 1010 +26
============================================
Files 153 153
Lines 4771 4771
Branches 737 737
============================================
+ Hits 2716 2796 +80
+ Misses 1687 1576 -111
- Partials 368 399 +31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/properties/NewPropertiesWithTargetsUtilBuilder.java
Outdated
Show resolved
Hide resolved
@calfaand thanks a lot for your contribution! 🚀 Just left some comments, please take a look |
…r tagerts test, deleting extra lines,
@andrii-bodnar I made changes you requested. |
@calfaand thank you! Please check a couple of new comments |
@andrii-bodnar what about now ? |
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/crowdin/cli/commands/functionality/PropertiesBuilderTest.java
Outdated
Show resolved
Hide resolved
@calfaand looks good now in general, added some minor comments related to code formatting 🙂 |
@andrii-bodnar formatted the code |
@calfaand looks good to me, thanks for the contribution! |
No description provided.