Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New command: comment #588

Merged
merged 13 commits into from
May 30, 2023
Merged

Conversation

yzerk
Copy link
Contributor

@yzerk yzerk commented May 25, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #588 (488e16d) into cli3 (728dc9c) will increase coverage by 0.34%.
The diff coverage is 76.53%.

@@             Coverage Diff              @@
##               cli3     #588      +/-   ##
============================================
+ Coverage     61.57%   61.91%   +0.34%     
- Complexity     1153     1186      +33     
============================================
  Files           171      180       +9     
  Lines          5048     5163     +115     
  Branches        771      782      +11     
============================================
+ Hits           3108     3196      +88     
- Misses         1520     1540      +20     
- Partials        420      427       +7     
Impacted Files Coverage Δ
...java/com/crowdin/cli/client/CrowdinClientCore.java 62.20% <ø> (ø)
...a/com/crowdin/cli/client/CrowdinProjectClient.java 67.67% <0.00%> (-1.23%) ⬇️
...ain/java/com/crowdin/cli/client/ProjectClient.java 0.00% <ø> (ø)
...a/com/crowdin/cli/commands/actions/CliActions.java 63.64% <0.00%> (-6.36%) ⬇️
...com/crowdin/cli/commands/picocli/CommandNames.java 0.00% <ø> (ø)
.../com/crowdin/cli/commands/picocli/RootCommand.java 100.00% <ø> (ø)
...crowdin/cli/commands/picocli/StringSubcommand.java 100.00% <ø> (ø)
...rowdin/cli/commands/picocli/CommentSubcommand.java 50.00% <50.00%> (ø)
...in/cli/commands/picocli/CommentListSubcommand.java 66.67% <66.67%> (ø)
.../cli/commands/picocli/StringCommentSubcommand.java 68.75% <68.75%> (ø)
... and 8 more

src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
src/main/resources/messages/messages.properties Outdated Show resolved Hide resolved
@andrii-bodnar
Copy link
Member

Merging will decrease coverage by 1.17%.

Unit tests needed

@andrii-bodnar andrii-bodnar force-pushed the feat/#303-string-comments-command branch from 3b97668 to 9d7f29a Compare May 30, 2023 08:47
@andrii-bodnar andrii-bodnar force-pushed the feat/#303-string-comments-command branch from 9d7f29a to 488e16d Compare May 30, 2023 08:54
@andrii-bodnar andrii-bodnar linked an issue May 30, 2023 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit 3aefca0 into cli3 May 30, 2023
@andrii-bodnar andrii-bodnar deleted the feat/#303-string-comments-command branch May 30, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: comment list
2 participants