Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows escape symbols #684

Merged
merged 6 commits into from
Jan 8, 2024
Merged

fix: windows escape symbols #684

merged 6 commits into from
Jan 8, 2024

Conversation

katerina20
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (0627d31) 63.70% compared to head (4079645) 63.58%.
Report is 1 commits behind head on main.

Files Patch % Lines
...in/java/com/crowdin/cli/utils/PlaceholderUtil.java 7.70% 5 Missing and 7 partials ⚠️
...owdin/cli/commands/functionality/SourcesUtils.java 0.00% 0 Missing and 3 partials ⚠️
src/main/java/com/crowdin/cli/utils/Utils.java 40.00% 1 Missing and 2 partials ⚠️
...in/cli/commands/actions/DownloadSourcesAction.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #684      +/-   ##
============================================
- Coverage     63.70%   63.58%   -0.12%     
  Complexity     1393     1393              
============================================
  Files           210      210              
  Lines          5660     5674      +14     
  Branches        856      862       +6     
============================================
+ Hits           3605     3607       +2     
- Misses         1596     1601       +5     
- Partials        459      466       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katerina20 katerina20 changed the title fix: windows escape symbols DRAFT: fix: windows escape symbols Nov 17, 2023
@andrii-bodnar andrii-bodnar marked this pull request as draft November 17, 2023 08:07
@andrii-bodnar andrii-bodnar changed the title DRAFT: fix: windows escape symbols fix: windows escape symbols Nov 17, 2023
@andrii-bodnar andrii-bodnar linked an issue Nov 17, 2023 that may be closed by this pull request
@andrii-bodnar andrii-bodnar added bug windows Probably is Windows-related only labels Nov 17, 2023
@katerina20 katerina20 force-pushed the fix/windows-escape branch 4 times, most recently from 083d93a to 098dbe9 Compare November 17, 2023 15:18
@katerina20 katerina20 marked this pull request as ready for review November 17, 2023 15:35
@katerina20 katerina20 force-pushed the fix/windows-escape branch 4 times, most recently from cd0a957 to 70a56ae Compare January 5, 2024 06:57
@andrii-bodnar andrii-bodnar merged commit 09a79dc into main Jan 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug windows Probably is Windows-related only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download sources finds no source files under Windows
2 participants