Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for placeholders similar to crowdin.yml GitHub Integration #45

Closed
Andre601 opened this issue Dec 9, 2020 · 17 comments
Closed
Labels
enhancement New feature or request

Comments

@Andre601
Copy link

Andre601 commented Dec 9, 2020

Is your feature request related to a problem? Please describe.
I would like to switch to this Action to no longer requiring a dedicated Account for up and downloading the files, but from a Conversation with a Support-Member did I find out, that this action doesn't seem to support placeholders like %locale% or %fileextension% within commit_message or translation?

Quote from the Mail:

I'm afraid currently it doesn't work in this way. But you're welcome to add this to the issue and our developers will fix it :
https://github.com/crowdin/github-action/issues

Describe the solution you'd like
Add support for changing the placeholders similar to the CLI or GitHub Integration.

Describe alternatives you've considered
There aren't really any other alternatives I could think of other than staying with the current system of having a dedicated account.

Additional context

@Andre601 Andre601 added the enhancement New feature or request label Dec 9, 2020
@andrii-bodnar
Copy link
Member

Hi @Andre601!

Have you consider options commit_message, pull_request_title or pull_request_body?

You can find all the available options in the Supported Options section of the Readme.

@Andre601
Copy link
Author

Andre601 commented Dec 9, 2020

This is not what I was mentioning in my issue.

As I just said there did I had a conversation with the Crowdin support where it was pointed out that placeholders don't seem to be supported (yet) within the GitHub Action.

I in fact even mentioned that "[...] this action doesn't seem to support placeholders like %locale% or %fileextension% within commit_message or translation?"

While commit_message wouldn't be a big problem is translation a required option to support the placeholders, so that translations would be saved within the right directory and as the right file format (%locale%.%fileextension% would become de_CH.json)

@Olena1234
Copy link

Hello @Andre601

Placeholders are specified in the configuration files, kindly check an article on the matter below:
https://support.crowdin.com/configuration-file/#writing-a-simple-configuration-file

The following placeholders are supported in Crowdin:
https://support.crowdin.com/configuration-file/#placeholders

@Andre601
Copy link
Author

So how would the configuration look like when migrating from an existing github integration?

@Olena1234
Copy link

Configuration file would look just the same as for the integration. Here you may check more details about the migration:
#7

@Andre601
Copy link
Author

Andre601 commented Mar 12, 2021

Configuration file would look just the same as for the integration. Here you may check more details about the migration:
#7

Doesn't really help me that much tbh.
I have this PR open right now to implement the GitHub Action in the hope to "retire" the dedicated User account for translations.
What exactly would I need to update to make everything work like the current system?

The current crowdin.yml file: https://github.com/purrbot-site/PurrBot/blob/master/crowdin.yml
Current Workflows:

@Andre601
Copy link
Author

To add to this does #7 not help me at all since the linked project on GitHub is no longer available and therefore can't be looked at to understand the file-structure.
As much as I appreciate the help would I appreciate it more if it was an actual, up-to-date viewable example and not one that has been deleted since.

@Olena1234
Copy link

Hi! Sorry for the delays, I'm passing your comments to our devs and will come back with updates on the matter

@Andre601
Copy link
Author

I quickly updated my comment with a bit more info (mainly added and updated some links)

@Olena1234
Copy link

Got it, thanks!

@VBeytok
Copy link
Collaborator

VBeytok commented Mar 15, 2021

Hi @Andre601
Please check this pull request
commit_message is supported only in workflow without placeholders (not in the config file of github actions or cli)
In case commit is needed for each language separately, then steps should be created for each language. Just like here.

@Andre601
Copy link
Author

Hi @Andre601
Please check this pull request
commit_message is supported only in workflow without placeholders (not in the config file of github actions or cli)
In case commit is needed for each language separately, then steps should be created for each language. Just like here.

That's kind of the point for this issue then.
Not having such placeholders available is frustrating, especially if you switch from the setup using an Account.

@DimaYashchyshyn-zz
Copy link

Hi @Andre601
Thanks for the prompt reply, passing your comments to the team

@DimaYashchyshyn-zz
Copy link

Currently, Crowdin Github Action works on Crowdin CLI and it can build all languages or just one

@Andre601
Copy link
Author

Any updates or similar on this one?
While I honestly don't care about the action anymore (Just seemed to useless for my case to warrant a switch) would I still like to know if there has been any progress about this within the past year.

@TaniaMal
Copy link

Hi @Andre601!

I will double-check this with the team and come back to you

@andrii-bodnar
Copy link
Member

Hi @Andre601!

The Crowdin GitHub Action already supports all the placeholder configurations that are available in the CLI or GitHub integration. Actually, GH Action is based on Crowdin CLI.

Could you please check the usage and supported options sections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants