Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource/kafka #1698

Merged
merged 20 commits into from
Aug 30, 2022
Merged

Datasource/kafka #1698

merged 20 commits into from
Aug 30, 2022

Conversation

he2ss
Copy link
Member

@he2ss he2ss commented Aug 3, 2022

Add kafka datasource, with documentation (crowdsecurity/crowdsec-docs#264)

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #1698 (d437674) into master (15a9e16) will decrease coverage by 3.78%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1698      +/-   ##
==========================================
- Coverage   53.45%   49.66%   -3.79%     
==========================================
  Files         136      117      -19     
  Lines       18980    17385    -1595     
==========================================
- Hits        10145     8635    -1510     
- Misses       7715     7741      +26     
+ Partials     1120     1009     -111     
Flag Coverage Δ
func-crowdsec 51.58% <ø> (+5.74%) ⬆️
func-cscli 42.15% <ø> (-2.03%) ⬇️
unit-linux ?
unit-windows 53.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/acquisition/acquisition.go 75.75% <0.00%> (-0.47%) ⬇️
pkg/apiclient/metrics.go 0.00% <0.00%> (-76.93%) ⬇️
pkg/acquisition/modules/journalctl/journalctl.go 0.00% <0.00%> (-71.74%) ⬇️
pkg/apiclient/signal.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% <0.00%> (-34.24%) ⬇️
pkg/types/utils.go 0.00% <0.00%> (-32.65%) ⬇️
pkg/csplugin/watcher.go 69.30% <0.00%> (-25.75%) ⬇️
pkg/time/rate/rate.go 71.73% <0.00%> (-12.18%) ⬇️
pkg/csconfig/api.go 43.44% <0.00%> (-9.84%) ⬇️
pkg/csplugin/broker.go 64.61% <0.00%> (-5.77%) ⬇️
... and 47 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/acquisition/modules/kafka/kafka.go Outdated Show resolved Hide resolved
pkg/acquisition/modules/kafka/kafka.go Show resolved Hide resolved
pkg/acquisition/modules/kafka/kafka.go Outdated Show resolved Hide resolved
pkg/acquisition/modules/kafka/kafka.go Outdated Show resolved Hide resolved
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@he2ss he2ss merged commit ea40ffd into master Aug 30, 2022
@he2ss he2ss deleted the datasource/kafka branch August 30, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants