Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1724 #1725

Merged
merged 3 commits into from
Aug 30, 2022
Merged

fix #1724 #1725

merged 3 commits into from
Aug 30, 2022

Conversation

sabban
Copy link
Contributor

@sabban sabban commented Aug 30, 2022

fix #1724 by checking that the id in
cscli decisions delete --id <id>
is really a number

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #1725 (94178f2) into master (64e0832) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1725      +/-   ##
==========================================
+ Coverage   52.99%   53.08%   +0.08%     
==========================================
  Files         137      137              
  Lines       19307    19310       +3     
==========================================
+ Hits        10232    10250      +18     
+ Misses       7942     7924      -18     
- Partials     1133     1136       +3     
Flag Coverage Δ
func-crowdsec 52.87% <ø> (+1.28%) ⬆️
func-cscli 42.15% <0.00%> (-0.03%) ⬇️
unit-linux 64.06% <ø> (-0.05%) ⬇️
unit-windows 53.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/decisions.go 61.89% <0.00%> (-0.34%) ⬇️
pkg/acquisition/modules/cloudwatch/cloudwatch.go 78.52% <0.00%> (+0.99%) ⬆️
cmd/crowdsec/metrics.go 44.73% <0.00%> (+17.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sabban sabban merged commit 21255b6 into master Aug 30, 2022
@sabban sabban deleted the fix_1724 branch August 30, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue in decision deletion
3 participants