Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode db password in CI to allow tests from third parties #1729

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 1, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2022

Codecov Report

Merging #1729 (7ba6e99) into master (ea40ffd) will decrease coverage by 3.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1729      +/-   ##
==========================================
- Coverage   52.54%   49.42%   -3.13%     
==========================================
  Files         138      117      -21     
  Lines       19593    17518    -2075     
==========================================
- Hits        10296     8658    -1638     
+ Misses       8158     7853     -305     
+ Partials     1139     1007     -132     
Flag Coverage Δ
func-crowdsec 51.58% <ø> (+5.74%) ⬆️
func-cscli 41.61% <ø> (ø)
unit-linux ?
unit-windows 53.48% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiclient/metrics.go 0.00% <0.00%> (-76.93%) ⬇️
pkg/acquisition/modules/journalctl/journalctl.go 0.00% <0.00%> (-71.74%) ⬇️
pkg/apiclient/signal.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% <0.00%> (-34.24%) ⬇️
pkg/types/utils.go 0.00% <0.00%> (-32.65%) ⬇️
pkg/csplugin/watcher.go 67.30% <0.00%> (-27.89%) ⬇️
pkg/time/rate/rate.go 71.73% <0.00%> (-12.18%) ⬇️
pkg/csconfig/api.go 43.44% <0.00%> (-9.84%) ⬇️
pkg/csplugin/broker.go 61.01% <0.00%> (-5.42%) ⬇️
pkg/csprofiles/csprofiles.go 63.97% <0.00%> (-5.15%) ⬇️
... and 31 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc requested a review from blotus September 1, 2022 13:56
@mmetc mmetc merged commit c4652d6 into crowdsecurity:master Sep 1, 2022
@mmetc mmetc deleted the dbci branch September 6, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants