Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1737 #1738

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Fix 1737 #1738

merged 2 commits into from
Sep 7, 2022

Conversation

sabban
Copy link
Contributor

@sabban sabban commented Sep 7, 2022

fix #1737 by adding a GetMeta() func in the scope of pkg/types for *types.Event. It makes it avaible from the postoverflow point of view.

And there's no point adding GetType() in *models.Event because:

  • the object definition doesn't hold the type
  • this is accessible from profiles' expr and from the API and this makes no sens at that place.

@sabban sabban merged commit b2130b1 into master Sep 7, 2022
@sabban sabban deleted the fix_1737 branch September 7, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buixor buixor buixor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expr helpers and limited scope
2 participants
@sabban @buixor