Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ROOT var to CS_ROOT in Makefile #1755

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Sep 15, 2022

Closes #1753

@codecov-commenter
Copy link

Codecov Report

Merging #1755 (56c8049) into master (1f06f24) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   49.39%   49.06%   -0.33%     
==========================================
  Files         117      117              
  Lines       17590    17590              
==========================================
- Hits         8688     8630      -58     
- Misses       7878     7948      +70     
+ Partials     1024     1012      -12     
Flag Coverage Δ
func-crowdsec 45.84% <ø> (-7.03%) ⬇️
func-cscli 41.61% <ø> (-0.06%) ⬇️
unit-windows 53.40% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec/api.go 51.85% <0.00%> (-27.78%) ⬇️
cmd/crowdsec/serve.go 23.23% <0.00%> (-17.85%) ⬇️
cmd/crowdsec/metrics.go 27.63% <0.00%> (-17.11%) ⬇️
cmd/crowdsec-cli/machines.go 55.12% <0.00%> (-1.07%) ⬇️
pkg/apiserver/apic.go 78.25% <0.00%> (+0.63%) ⬆️
pkg/acquisition/modules/file/file.go 66.28% <0.00%> (+0.86%) ⬆️
pkg/cwhub/loader.go 64.41% <0.00%> (+0.92%) ⬆️
pkg/cwhub/download.go 52.17% <0.00%> (+1.44%) ⬆️
pkg/cwhub/install.go 47.69% <0.00%> (+3.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blotus blotus merged commit 1ba6c67 into master Sep 15, 2022
@blotus blotus deleted the rename-makefile-root-var branch September 15, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile uses ROOT - collision with Gentoo Portage
3 participants