add test and fix for configuration reload #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
- Coverage 52.94% 52.57% -0.38%
==========================================
Files 148 148
Lines 19855 19878 +23
==========================================
- Hits 10513 10451 -62
- Misses 8171 8261 +90
+ Partials 1171 1166 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mmetc
force-pushed
the
mm-trigger-reload
branch
from
e858c7c
to
f67967c
Compare
mmetc
changed the title
mmetc
changed the title
blotus
approved these changes
Oct 13, 2022
example: run crowdsec, disable agent in the config file, reload config. Now there is no agent but the signal loop believes there is, so triggering a reload configuration again will make the process hang forever. This commit updates the configuration in the signal loop with the one returned by the signal handler.
mmetc
force-pushed
the
mm-trigger-reload
branch
from
d7b2fe0
to
75f6c19
Compare
mmetc
force-pushed
the
mm-trigger-reload
branch
from
5ad0bf8
to
b52ea6b
Compare
mmetc
changed the title
mmetc
force-pushed
the
mm-trigger-reload
branch
from
5ef33da
to
180d50b
Compare
mmetc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.