Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cronjob remove fails due to [[ #1818

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Cronjob remove fails due to [[ #1818

merged 2 commits into from
Oct 17, 2022

Conversation

LaurenceJJones
Copy link
Contributor

No description provided.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2022

Codecov Report

Merging #1818 (57d2ed7) into master (0ecb6dc) will increase coverage by 8.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
+ Coverage   49.09%   57.95%   +8.85%     
==========================================
  Files         128      105      -23     
  Lines       17941    12823    -5118     
==========================================
- Hits         8809     7432    -1377     
+ Misses       8097     4631    -3466     
+ Partials     1035      760     -275     
Flag Coverage Δ
func-crowdsec ?
func-cscli ?
unit-linux 57.79% <ø> (?)
unit-windows 53.02% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cwhub/install.go 44.61% <0.00%> (-3.08%) ⬇️
pkg/cwhub/download.go 50.72% <0.00%> (-1.45%) ⬇️
cmd/crowdsec-cli/config.go
cmd/crowdsec/metrics.go
cmd/crowdsec-cli/console.go
cmd/crowdsec-cli/machines_table.go
cmd/crowdsec-cli/alerts.go
cmd/crowdsec-cli/decisions.go
cmd/crowdsec-cli/bouncers_table.go
cmd/crowdsec-cli/explain.go
... and 74 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LaurenceJJones LaurenceJJones merged commit 33383fa into crowdsecurity:master Oct 17, 2022
mmetc added a commit that referenced this pull request Oct 18, 2022
mmetc added a commit that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants