Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1839 #1840

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix for #1839 #1840

merged 1 commit into from
Oct 26, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 26, 2022

No description provided.

@buixor buixor added this to the 1.4.2 milestone Oct 26, 2022
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #1840 (f20bae4) into master (e545933) will decrease coverage by 0.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1840      +/-   ##
==========================================
- Coverage   53.34%   53.01%   -0.33%     
==========================================
  Files         148       85      -63     
  Lines       19940    10945    -8995     
==========================================
- Hits        10636     5803    -4833     
+ Misses       8129     4511    -3618     
+ Partials     1175      631     -544     
Flag Coverage Δ
func-crowdsec ?
func-cscli ?
unit-linux ?
unit-windows 53.01% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/acquisition/modules/file/file.go 65.60% <0.00%> (-2.12%) ⬇️
pkg/acquisition/modules/journalctl/journalctl.go 0.00% <0.00%> (-71.74%) ⬇️
pkg/apiclient/metrics.go 0.00% <0.00%> (-53.85%) ⬇️
pkg/apiclient/signal.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/acquisition/modules/kafka/kafka.go 30.87% <0.00%> (-40.27%) ⬇️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% <0.00%> (-34.24%) ⬇️
pkg/types/utils.go 0.00% <0.00%> (-32.15%) ⬇️
pkg/csplugin/watcher.go 67.30% <0.00%> (-27.89%) ⬇️
pkg/time/rate/rate.go 71.73% <0.00%> (-12.18%) ⬇️
pkg/csconfig/api.go 41.30% <0.00%> (-8.70%) ⬇️
... and 76 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc merged commit 2088bb1 into master Oct 26, 2022
@mmetc mmetc deleted the emptytail branch October 26, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants