Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker build flavors: slim, with-plugins, with-geoip, full #1862

Merged
merged 8 commits into from
Nov 8, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 7, 2022

No description provided.

@mmetc mmetc changed the title Mm docker alpine build flavors: slim, with-plugins, with-geoip, full Nov 7, 2022
COPY --from=build /go/src/crowdsec/plugins/notifications/email/email.yaml /staging/etc/crowdsec/notifications/email.yaml
COPY --from=build /go/src/crowdsec/plugins/notifications/http/http.yaml /staging/etc/crowdsec/notifications/http.yaml
COPY --from=build /go/src/crowdsec/plugins/notifications/slack/slack.yaml /staging/etc/crowdsec/notifications/slack.yaml
COPY --from=build /go/src/crowdsec/plugins/notifications/splunk/splunk.yaml /staging/etc/crowdsec/notifications/splunk.yaml
COPY --from=build /usr/local/lib/crowdsec/plugins /usr/local/lib/crowdsec/plugins

FROM build-slim as build-geoip

COPY --from=build /var/lib/crowdsec /staging/var/lib/crowdsec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems not to be included in the build-full if I'm not mistaken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea is to have four flavors (no need to push them all):

-slim: 86 MB
-plugins: 129MB
-geoip: 163 MB
-full: 205 MB

@codecov-commenter
Copy link

Codecov Report

Merging #1862 (9de24b1) into master (895691d) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1862      +/-   ##
==========================================
- Coverage   53.43%   53.13%   -0.31%     
==========================================
  Files         148       85      -63     
  Lines       19980    10977    -9003     
==========================================
- Hits        10677     5833    -4844     
+ Misses       8121     4513    -3608     
+ Partials     1182      631     -551     
Flag Coverage Δ
func-crowdsec ?
func-cscli ?
unit-linux ?
unit-windows 53.13% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/acquisition/modules/journalctl/journalctl.go 0.00% <0.00%> (-71.36%) ⬇️
pkg/apiclient/metrics.go 0.00% <0.00%> (-53.85%) ⬇️
pkg/apiclient/signal.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/acquisition/modules/kafka/kafka.go 30.87% <0.00%> (-40.27%) ⬇️
pkg/acquisition/modules/kinesis/kinesis.go 0.00% <0.00%> (-34.24%) ⬇️
pkg/types/utils.go 0.00% <0.00%> (-32.31%) ⬇️
pkg/csplugin/watcher.go 67.30% <0.00%> (-27.89%) ⬇️
pkg/time/rate/rate.go 71.73% <0.00%> (-12.18%) ⬇️
pkg/csconfig/api.go 41.30% <0.00%> (-8.70%) ⬇️
pkg/csplugin/broker.go 61.15% <0.00%> (-5.40%) ⬇️
... and 72 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc changed the title alpine build flavors: slim, with-plugins, with-geoip, full docker build flavors: slim, with-plugins, with-geoip, full Nov 7, 2022
@mmetc mmetc added this to the 1.4.2 milestone Nov 8, 2022
Copy link
Member

@he2ss he2ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mmetc mmetc merged commit b0889d7 into master Nov 8, 2022
@mmetc mmetc deleted the mm-docker-slim branch November 8, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants