Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print missing "AS" values as empty strings instead of "0 " #1867

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 13, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #1867 (0b707bd) into master (b0889d7) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   53.47%   53.45%   -0.03%     
==========================================
  Files         148      148              
  Lines       19986    19986              
==========================================
- Hits        10688    10684       -4     
- Misses       8117     8120       +3     
- Partials     1181     1182       +1     
Flag Coverage Δ
func-crowdsec 45.40% <ø> (ø)
func-cscli 44.92% <75.00%> (ø)
unit-linux 57.91% <ø> (-0.04%) ⬇️
unit-windows 53.07% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/decisions.go 60.97% <0.00%> (ø)
cmd/crowdsec-cli/alerts.go 73.54% <100.00%> (ø)
cmd/crowdsec-cli/alerts_table.go 72.60% <100.00%> (ø)
cmd/crowdsec-cli/decisions_table.go 90.62% <100.00%> (ø)
pkg/acquisition/modules/cloudwatch/cloudwatch.go 77.49% <0.00%> (-1.00%) ⬇️
pkg/acquisition/modules/docker/docker.go 61.09% <0.00%> (+0.24%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3beb84b into master Nov 14, 2022
@mmetc mmetc deleted the as-description branch November 14, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants