Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker refactoring, tls setup #1869

Merged
merged 17 commits into from
Nov 28, 2022
Merged

Docker refactoring, tls setup #1869

merged 17 commits into from
Nov 28, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 16, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #1869 (243550a) into master (c5079ac) will decrease coverage by 0.42%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   53.92%   53.50%   -0.43%     
==========================================
  Files         148      148              
  Lines       19986    19986              
==========================================
- Hits        10777    10693      -84     
- Misses       8020     8113      +93     
+ Partials     1189     1180       -9     
Flag Coverage Δ
func-crowdsec 45.40% <ø> (-7.75%) ⬇️
func-cscli 44.92% <ø> (ø)
unit-linux 57.98% <0.00%> (-0.04%) ⬇️
unit-windows 53.23% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/apiserver.go 38.33% <0.00%> (ø)
cmd/crowdsec/api.go 51.85% <0.00%> (-27.78%) ⬇️
cmd/crowdsec/serve.go 22.34% <0.00%> (-19.70%) ⬇️
cmd/crowdsec/metrics.go 27.63% <0.00%> (-17.11%) ⬇️
pkg/leakybucket/manager_run.go 67.02% <0.00%> (-1.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc force-pushed the docker-tls-ca branch 6 times, most recently from f46c355 to 29e01e5 Compare November 17, 2022 10:36
@mmetc mmetc marked this pull request as draft November 17, 2022 11:32
@mmetc mmetc marked this pull request as ready for review November 21, 2022 09:46
@mmetc mmetc changed the title [wip] Docker refactoring, tls setup Docker refactoring, tls setup Nov 21, 2022
@mmetc mmetc requested a review from blotus November 21, 2022 21:15
@mmetc mmetc added this to the 1.4.3 milestone Nov 22, 2022
@mmetc mmetc merged commit fde9640 into master Nov 28, 2022
@mmetc mmetc deleted the docker-tls-ca branch November 28, 2022 09:35
@mathieuHa
Copy link

Nice work @mmetc,

I was searching for applying CACERT_FILE in the docker container.
Can't wait for the release

@mmetc
Copy link
Contributor Author

mmetc commented Nov 28, 2022

Thanks @mathieuHa . You might want to check https://github.com/mmetc/crowdsec-bouncer-traefik-plugin/tree/tls
I need to configure and test it, then I'll open a PR

@mmetc
Copy link
Contributor Author

mmetc commented Nov 28, 2022

Ah, the missing piece is TLS support in the helm chart - https://github.com/crowdsecurity/helm-charts/tree/traefik-tls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants