Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -error flag to crowdsec binary #1903

Merged
merged 6 commits into from
Dec 3, 2022
Merged

add -error flag to crowdsec binary #1903

merged 6 commits into from
Dec 3, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Nov 30, 2022

This change makes the log initialization happen in a single place, and as soon as possible. This means any info-level messages, like "push and pull blah blah" are not shown in stderr anymore, by default. They end up in the regular logs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #1903 (24dca4e) into master (fa0e590) will decrease coverage by 0.24%.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
- Coverage   54.00%   53.75%   -0.25%     
==========================================
  Files         148      148              
  Lines       20047    20052       +5     
==========================================
- Hits        10826    10779      -47     
- Misses       8040     8102      +62     
+ Partials     1181     1171      -10     
Flag Coverage Δ
func-crowdsec 47.02% <64.10%> (-4.87%) ⬇️
func-cscli 44.97% <ø> (ø)
unit-linux 58.20% <ø> (+0.01%) ⬆️
unit-windows 53.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec/run_in_svc.go 86.66% <ø> (+5.03%) ⬆️
cmd/crowdsec/serve.go 22.95% <ø> (-19.09%) ⬇️
pkg/csconfig/api.go 50.74% <ø> (+0.74%) ⬆️
cmd/crowdsec/main.go 66.82% <60.00%> (+3.87%) ⬆️
cmd/crowdsec/api.go 54.38% <100.00%> (-25.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit fd3e668 into master Dec 3, 2022
@mmetc mmetc deleted the error-log branch December 3, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants