Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set cscli log timestamp to 24h (#1917) #1921

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 11, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2022

Codecov Report

Merging #1921 (c734cb6) into releases/1.4.x (f2528f3) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           releases/1.4.x    #1921      +/-   ##
==================================================
- Coverage           54.07%   53.57%   -0.50%     
==================================================
  Files                 148      148              
  Lines               19991    19991              
==================================================
- Hits                10810    10711      -99     
- Misses               7989     8105     +116     
+ Partials             1192     1175      -17     
Flag Coverage Δ
func-crowdsec 45.40% <ø> (-10.27%) ⬇️
func-cscli 44.97% <100.00%> (+0.04%) ⬆️
unit-linux 58.08% <ø> (+0.03%) ⬆️
unit-windows 53.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/main.go 68.07% <100.00%> (ø)
cmd/crowdsec/serve.go 22.34% <0.00%> (-32.58%) ⬇️
cmd/crowdsec/api.go 51.85% <0.00%> (-27.78%) ⬇️
cmd/crowdsec/crowdsec.go 43.97% <0.00%> (-1.58%) ⬇️
cmd/crowdsec/main.go 62.94% <0.00%> (-1.02%) ⬇️
cmd/crowdsec-cli/machines.go 54.51% <0.00%> (+1.12%) ⬆️
pkg/leakybucket/manager_run.go 68.43% <0.00%> (+1.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc added the kind/fix label Dec 12, 2022
@mmetc mmetc added this to the 1.4.4 milestone Dec 12, 2022
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 3366a31 into releases/1.4.x Dec 12, 2022
@mmetc mmetc deleted the backport-cscli-timestamp branch December 12, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants