Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: separate CLIENT_* and LAPI_* variables for tls certificates #1929

Merged
merged 3 commits into from
Dec 16, 2022
Merged

docker: separate CLIENT_* and LAPI_* variables for tls certificates #1929

merged 3 commits into from
Dec 16, 2022

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 15, 2022 •
edited
Loading

Legacy configurations (using CERT_FILE, KEY_FILE and CACERT_FILE) still work as long as DISABLE_AGENT=true, otherwise the container crashes looking for the client certificate (in the default location which is now /etc/ssl/crowdsec-client/)

@mmetc mmetc marked this pull request as draft December 15, 2022 14:29
@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor

/kind enhancement
/area agent

@mmetc mmetc force-pushed the docker-client-cert branch 2 times, most recently from aa86ee2 to 3451d55 Compare December 15, 2022 16:09
@mmetc
Copy link
Contributor Author

mmetc commented Dec 15, 2022

There must be a simpler way to set default values in yq

@mmetc mmetc requested a review from he2ss December 15, 2022 16:11
@mmetc mmetc marked this pull request as ready for review December 16, 2022 10:50
LaurenceJJones
LaurenceJJones approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to see if I could break it but couldnt so LGTM

@mmetc mmetc merged commit f68bc11 into master Dec 16, 2022
@mmetc mmetc deleted the docker-client-cert branch December 16, 2022 19:41
mmetc added a commit that referenced this pull request Dec 16, 2022
@mmetc
docker: separate CLIENT_* and LAPI_* variables for tls certificates (#…
6ece8e6 
…1929)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenceJJones LaurenceJJones LaurenceJJones approved these changes

@he2ss he2ss he2ss approved these changes

Assignees
No one assigned
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmetc @LaurenceJJones @he2ss