separate cobra constructors: lapi, machines, bouncers, postoverflows #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| log.Printf("Local API credentials dumped to '%s'", dumpFile) | ||
| } else { | ||
| fmt.Printf("%s\n", string(apiConfigDump)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
| } | ||
| log.Printf("API credentials dumped to '%s'", dumpFile) | ||
| } else { | ||
| fmt.Printf("%s\n", string(apiConfigDump)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information
Codecov Report
@@ Coverage Diff @@
## master #1945 +/- ##
==========================================
+ Coverage 54.61% 54.83% +0.21%
==========================================
Files 152 156 +4
Lines 20149 20622 +473
==========================================
+ Hits 11005 11308 +303
- Misses 7961 8081 +120
- Partials 1183 1233 +50
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mmetc
changed the title
mmetc
force-pushed
the
cscli-ref-lapi
branch
from
e85c3e4
to
2024028
Compare
mmetc
changed the title
nitescuc
added a commit
that referenced
this pull request
Jan 9, 2023
* backoff on refresh token error * fix tls communication with lapi and user/pw auth (#1956) allow self-signed TLS encryption with user/pw auth docker: - remove defaults for certificate file locations - new envvar INSECURE_SKIP_VERIFY - register agent before TLS settings (cscli machine add removes them from the credentials file) * separate cscli cobra constructors: lapi, machines, bouncers, postoverflows (#1945) * use feature toggling to improve testability with http retry backoff * Add parse unix to dateparse enricher (#1958) Add parse unix is we do have a strTime but wasnt parsed using convential golang time * func tests: redirect stderr to filter extra logs (#1961) * backoff on refresh token error * use feature toggling to improve testability with http retry backoff * refactor feature backoff toggle for tests Co-authored-by: mmetc <92726601+mmetc@users.noreply.github.com> Co-authored-by: Laurence Jones <laurence.jones@live.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just moved around stuff like I did for "cscli config". The aim is to have