Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact cscli decisions #2003

Merged
merged 1 commit into from
Jan 19, 2023
Merged

refact cscli decisions #2003

merged 1 commit into from
Jan 19, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 19, 2023 •
edited
Loading

Just broke a big function in small parts, for now.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Jan 19, 2023

/kind chore

@mmetc mmetc marked this pull request as ready for review January 19, 2023 09:30
sabban
sabban approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 7bb74b9 into master Jan 19, 2023
@mmetc mmetc deleted the cscli-refact-decisions branch January 19, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabban sabban sabban approved these changes

Assignees
No one assigned
Labels
kind/chore needs/area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @sabban