Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli config feature-flags #2006

Merged
merged 1 commit into from
Jan 20, 2023
Merged

cscli config feature-flags #2006

merged 1 commit into from
Jan 20, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 19, 2023

No description provided.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Jan 19, 2023

/area configuration
/kind enhancement

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #2006 (45a77ab) into master (4bffc0d) will decrease coverage by 0.07%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master    #2006      +/-   ##
==========================================
- Coverage   54.25%   54.18%   -0.07%     
==========================================
  Files         160      165       +5     
  Lines       21636    22122     +486     
==========================================
+ Hits        11738    11987     +249     
- Misses       8611     8807     +196     
- Partials     1287     1328      +41     
Flag Coverage Δ
func-crowdsec 45.53% <ø> (ø)
func-cscli 47.03% <16.12%> (-0.43%) ⬇️
unit-linux 58.06% <0.00%> (-0.12%) ⬇️
unit-windows 53.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/fflag/features.go 85.31% <0.00%> (-7.82%) ⬇️
cmd/crowdsec-cli/config_feature_flags.go 15.21% <15.21%> (ø)
cmd/crowdsec-cli/config.go 100.00% <100.00%> (ø)
pkg/leakybucket/manager_run.go 67.02% <0.00%> (-1.42%) ⬇️
pkg/acquisition/modules/cloudwatch/cloudwatch.go 77.84% <0.00%> (-0.99%) ⬇️
...isition/modules/wineventlog/wineventlog_windows.go 71.56% <0.00%> (ø)
pkg/csplugin/utils_windows.go 53.54% <0.00%> (ø)
pkg/acquisition/modules/file/tailline_windows.go 100.00% <0.00%> (ø)
pkg/cwhub/path_separator_windows.go 53.84% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc added this to the 1.5.0 milestone Jan 19, 2023
@mmetc mmetc requested a review from buixor January 20, 2023 08:26
@mmetc mmetc merged commit e583369 into master Jan 20, 2023
@mmetc mmetc deleted the cscli-config-feature-flags branch January 20, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants