Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the way acquisition is stopped #2069

Merged
merged 7 commits into from
Feb 27, 2023
Merged

fix the way acquisition is stopped #2069

merged 7 commits into from
Feb 27, 2023

Conversation

sabban
Copy link
Contributor

@sabban sabban commented Feb 22, 2023

fix the way acquisition is stopped: drain the inputLineChan before terminating the acquisition routine to make sure that the acquisition routine doesn't get stuck filling a chan that isn't read anywhere.

@github-actions
Copy link

@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@sabban: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #2069 (ebf7343) into master (01ea78c) will increase coverage by 0.02%.
The diff coverage is 76.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2069      +/-   ##
==========================================
+ Coverage   53.37%   53.40%   +0.02%     
==========================================
  Files         175      175              
  Lines       24012    24022      +10     
==========================================
+ Hits        12816    12828      +12     
+ Misses       9786     9784       -2     
  Partials     1410     1410              
Flag Coverage Δ
func-crowdsec 46.24% <76.92%> (+0.22%) ⬆️
func-cscli 48.10% <ø> (ø)
unit-linux 56.08% <ø> (+0.03%) ⬆️
unit-windows 52.18% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec/main.go 64.07% <ø> (ø)
cmd/crowdsec/serve.go 24.26% <72.72%> (+1.74%) ⬆️
cmd/crowdsec/crowdsec.go 43.97% <100.00%> (ø)
pkg/acquisition/modules/cloudwatch/cloudwatch.go 78.82% <0.00%> (+0.98%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sabban sabban added bugfix kind/bug Something isn't working labels Feb 23, 2023
@sabban sabban changed the title fix the way acquisition is stopped [wip] fix the way acquisition is stopped Feb 23, 2023
@sabban
Copy link
Contributor Author

sabban commented Feb 23, 2023

I ensured that there's no lock added of any kind

@sabban
Copy link
Contributor Author

sabban commented Feb 23, 2023

I may come with a better way to do this.

@LaurenceJJones LaurenceJJones marked this pull request as draft February 24, 2023 13:50
@sabban sabban changed the title [wip] fix the way acquisition is stopped fix the way acquisition is stopped Feb 27, 2023
@sabban sabban marked this pull request as ready for review February 27, 2023 09:09
@sabban sabban merged commit 39a4a25 into master Feb 27, 2023
@sabban sabban deleted the fix_stop branch February 27, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix kind/bug Something isn't working needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants