-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the way acquisition is stopped #2069
Conversation
@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@sabban: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #2069 +/- ##
==========================================
+ Coverage 53.37% 53.40% +0.02%
==========================================
Files 175 175
Lines 24012 24022 +10
==========================================
+ Hits 12816 12828 +12
+ Misses 9786 9784 -2
Partials 1410 1410
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I ensured that there's no lock added of any kind |
I may come with a better way to do this. |
fix the way acquisition is stopped: drain the inputLineChan before terminating the acquisition routine to make sure that the acquisition routine doesn't get stuck filling a chan that isn't read anywhere.