Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load lapi config for config show output #2097

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Load lapi config for config show output #2097

merged 4 commits into from
Mar 8, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Mar 6, 2023

This adds URL and login parameters as it was intended.
Also rewrite configShow and displayOneAlert to use an embedded text/template for shorter code.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Mar 6, 2023

/kind fix

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #2097 (d269acf) into master (b2c2c5a) will increase coverage by 0.12%.
The diff coverage is 23.52%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
+ Coverage   52.70%   52.82%   +0.12%     
==========================================
  Files         172      176       +4     
  Lines       23873    24161     +288     
==========================================
+ Hits        12582    12763     +181     
- Misses       9918     9984      +66     
- Partials     1373     1414      +41     
Flag Coverage Δ
func-crowdsec 46.50% <ø> (ø)
func-cscli 46.97% <23.52%> (-0.30%) ⬇️
unit-linux 55.69% <ø> (+0.01%) ⬆️
unit-windows 51.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/config_show.go 58.75% <20.00%> (-0.15%) ⬇️
cmd/crowdsec-cli/alerts.go 65.29% <28.57%> (-2.12%) ⬇️
pkg/csplugin/utils_windows.go 53.54% <0.00%> (ø)
...isition/modules/wineventlog/wineventlog_windows.go 71.56% <0.00%> (ø)
pkg/acquisition/modules/file/tailline_windows.go 100.00% <0.00%> (ø)
pkg/cwhub/path_separator_windows.go 53.84% <0.00%> (ø)
pkg/acquisition/modules/file/file.go 68.82% <0.00%> (+0.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc added this to the 1.5.0 milestone Mar 6, 2023
@mmetc mmetc requested a review from buixor March 8, 2023 13:59
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 9faa49c into master Mar 8, 2023
@mmetc mmetc deleted the text-template branch March 8, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants