Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make: extract "goversion.mk" to reuse it in bouncers #2101

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Make: extract "goversion.mk" to reuse it in bouncers #2101

merged 7 commits into from
Mar 7, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Mar 7, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Mar 7, 2023

/kind chore

@mmetc mmetc marked this pull request as ready for review March 7, 2023 09:52
@mmetc mmetc added this to the 1.5.0 milestone Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #2101 (c4040ce) into master (16a3be4) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   52.85%   52.88%   +0.02%     
==========================================
  Files         176      176              
  Lines       24258    24258              
==========================================
+ Hits        12822    12828       +6     
+ Misses      10023    10018       -5     
+ Partials     1413     1412       -1     
Flag Coverage Δ
func-crowdsec 46.50% <ø> (ø)
func-cscli 47.26% <ø> (ø)
unit-linux 55.67% <ø> (+0.03%) ⬆️
unit-windows 51.92% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/leakybucket/manager_run.go 67.02% <0.00%> (-1.42%) ⬇️
pkg/cwhub/loader.go 65.06% <0.00%> (+0.90%) ⬆️
pkg/cwhub/download.go 53.48% <0.00%> (+1.39%) ⬆️
pkg/cwhub/install.go 47.61% <0.00%> (+2.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc merged commit 0a748d3 into master Mar 7, 2023
@mmetc mmetc deleted the mk branch March 7, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants