Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: fix authentication to localstack #2106

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Unit tests: fix authentication to localstack #2106

merged 1 commit into from
Mar 8, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Mar 8, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc
Copy link
Contributor Author

mmetc commented Mar 8, 2023

/kind fix

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #2106 (01f7f2e) into master (c7014db) will decrease coverage by 0.11%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2106      +/-   ##
==========================================
- Coverage   52.93%   52.82%   -0.11%     
==========================================
  Files         176      176              
  Lines       24258    24258              
==========================================
- Hits        12840    12815      -25     
- Misses      10008    10029      +21     
- Partials     1410     1414       +4     
Flag Coverage Δ
func-crowdsec 46.50% <ø> (ø)
func-cscli 47.26% <ø> (-0.05%) ⬇️
unit-linux 55.59% <ø> (-0.15%) ⬇️
unit-windows 51.85% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cwhub/install.go 44.89% <0.00%> (-2.73%) ⬇️
pkg/leakybucket/manager_run.go 67.02% <0.00%> (-1.42%) ⬇️
pkg/cwhub/download.go 52.09% <0.00%> (-1.40%) ⬇️
pkg/acquisition/modules/cloudwatch/cloudwatch.go 77.84% <0.00%> (-0.99%) ⬇️
cmd/crowdsec-cli/machines.go 52.77% <0.00%> (-0.93%) ⬇️
pkg/cwhub/loader.go 64.15% <0.00%> (-0.91%) ⬇️
pkg/acquisition/modules/file/file.go 67.97% <0.00%> (-0.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc marked this pull request as ready for review March 8, 2023 13:41
@mmetc mmetc merged commit e63a3ab into master Mar 8, 2023
@mmetc mmetc deleted the localstack branch March 8, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants