Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli explain : avoid concurrent map writes #2113

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Mar 9, 2023

Protect map w/ mutex to avoid concurrent map writes with cscli explain when having many concurrent parser routines

fix #2061

…n when having many concurrent parser routines
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor Author

buixor commented Mar 9, 2023

/kind fix

/area cscli

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Merging #2113 (e2b0fe7) into master (e61a464) will increase coverage by 2.44%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
+ Coverage   50.35%   52.79%   +2.44%     
==========================================
  Files         155      176      +21     
  Lines       21988    24280    +2292     
==========================================
+ Hits        11072    12819    +1747     
- Misses       9612    10036     +424     
- Partials     1304     1425     +121     
Flag Coverage Δ
func-crowdsec 46.41% <ø> (-6.24%) ⬇️
func-cscli 46.98% <ø> (ø)
unit-linux 55.63% <0.00%> (?)
unit-windows 51.83% <0.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/parser/runtime.go 55.59% <0.00%> (-1.78%) ⬇️

... and 51 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc added this to the 1.5.0 milestone Mar 16, 2023
@buixor buixor merged commit 855f9e6 into master Mar 16, 2023
@buixor buixor deleted the cscli_explain_race branch March 16, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible multithread locking issue with cscli explain
4 participants