Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix awkward stacktrace in conditional filter #2145

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Mar 27, 2023

No description provided.

@github-actions
Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #2145 (575d393) into master (d769fff) will decrease coverage by 0.01%.
The diff coverage is 73.07%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #2145      +/-   ##
==========================================
- Coverage   52.91%   52.90%   -0.01%     
==========================================
  Files         177      177              
  Lines       24860    24868       +8     
==========================================
+ Hits        13154    13157       +3     
- Misses      10232    10235       +3     
- Partials     1474     1476       +2     
Flag Coverage Δ
func-crowdsec 46.41% <ø> (ø)
func-cscli 46.98% <ø> (ø)
unit-linux 55.68% <73.07%> (-0.03%) ⬇️
unit-windows 52.09% <73.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/leakybucket/conditional.go 68.08% <68.18%> (+2.37%) ⬆️
pkg/leakybucket/manager_load.go 66.34% <100.00%> (+0.84%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@buixor
Copy link
Contributor Author

buixor commented Mar 27, 2023

/area agent
/kind fix

@buixor buixor merged commit 169b844 into master Mar 27, 2023
@buixor buixor deleted the fix_conditional_bucket branch March 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants