Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow batching when importing decisions #2192

Merged
merged 1 commit into from
May 11, 2023

Conversation

buixor
Copy link
Contributor

@buixor buixor commented May 11, 2023

No description provided.

@github-actions
Copy link

@buixor: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@buixor: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@buixor
Copy link
Contributor Author

buixor commented May 11, 2023

/area cscli
/kind enhancement

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #2192 (7f76f77) into master (2701454) will increase coverage by 0.08%.
The diff coverage is 3.77%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2192      +/-   ##
==========================================
+ Coverage   55.83%   55.91%   +0.08%     
==========================================
  Files         183      183              
  Lines       25666    25698      +32     
==========================================
+ Hits        14330    14370      +40     
+ Misses       9788     9762      -26     
- Partials     1548     1566      +18     
Flag Coverage Δ
bats 37.44% <3.77%> (+0.10%) ⬆️
unit-linux 55.15% <ø> (+0.02%) ⬆️
unit-windows 51.42% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/decisions.go 60.51% <3.77%> (-3.14%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@buixor buixor merged commit 5ac33aa into master May 11, 2023
@buixor buixor deleted the cscli_decisions_import_batching branch May 11, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants