Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple bouncer dependencies: use go-cs-lib/pkg/ptr #2228

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 25, 2023

No description provided.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.5.2 milestone May 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2023

Codecov Report

Merging #2228 (d8bfb11) into master (1f9f81d) will decrease coverage by 0.07%.
The diff coverage is 31.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
- Coverage   55.70%   55.63%   -0.07%     
==========================================
  Files         181      181              
  Lines       25521    25521              
==========================================
- Hits        14216    14199      -17     
- Misses       9744     9756      +12     
- Partials     1561     1566       +5     
Flag Coverage Δ
bats 37.19% <26.66%> (-0.07%) ⬇️
unit-linux 54.62% <76.00%> (+0.02%) ⬆️
unit-windows 51.01% <76.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/console.go 22.71% <0.00%> (ø)
cmd/crowdsec-cli/decisions.go 60.51% <0.00%> (ø)
pkg/apiserver/apic.go 71.21% <76.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc requested a review from sabban May 25, 2023 13:34
@mmetc mmetc merged commit 9167bd1 into master May 25, 2023
@mmetc mmetc deleted the go-cs-lib branch May 25, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants