Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: replaced function calls to pkg/types, errors.Wrap #2235

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 26, 2023

No description provided.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as draft May 26, 2023 12:01
@mmetc mmetc force-pushed the go-cs-lib-ptr branch 2 times, most recently from 74a300d to 20ca1d3 Compare May 26, 2023 12:23
@mmetc mmetc marked this pull request as ready for review May 26, 2023 12:48
@mmetc mmetc added this to the 1.5.3 milestone May 26, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2235 (226e52d) into master (f654496) will decrease coverage by 0.41%.
The diff coverage is 29.09%.

@@            Coverage Diff             @@
##           master    #2235      +/-   ##
==========================================
- Coverage   55.66%   55.26%   -0.41%     
==========================================
  Files         181      181              
  Lines       25539    25531       -8     
==========================================
- Hits        14217    14109     -108     
- Misses       9757     9874     +117     
+ Partials     1565     1548      -17     
Flag Coverage Δ
bats 36.83% <21.81%> (-0.38%) ⬇️
unit-linux 54.48% <28.30%> (-0.01%) ⬇️
unit-windows 50.91% <28.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/papi.go 0.00% <0.00%> (ø)
pkg/apiserver/papi_cmd.go 0.00% <0.00%> (ø)
pkg/types/utils.go 59.73% <ø> (-0.78%) ⬇️
pkg/csconfig/crowdsec_service.go 53.90% <10.00%> (ø)
pkg/csconfig/console.go 18.33% <38.46%> (ø)
pkg/csconfig/api.go 51.33% <45.45%> (ø)
pkg/exprhelpers/helpers.go 67.47% <50.00%> (ø)
pkg/csconfig/config.go 96.90% <75.00%> (ø)
pkg/csconfig/database.go 60.71% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 396dcf8 into master Jun 1, 2023
@mmetc mmetc deleted the go-cs-lib-ptr branch June 1, 2023 14:31
mmetc added a commit that referenced this pull request Jun 9, 2023
we now use a generic pointer function, and slowly remove the deprecated pkg/errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants