Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: add G (1e9) suffix to metric units #2254

Merged
merged 1 commit into from
Jun 2, 2023
Merged

cscli: add G (1e9) suffix to metric units #2254

merged 1 commit into from
Jun 2, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 1, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #2254 (7584aa1) into master (396dcf8) will increase coverage by 18.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2254       +/-   ##
===========================================
+ Coverage   37.14%   55.45%   +18.31%     
===========================================
  Files         178      182        +4     
  Lines       25148    25531      +383     
===========================================
+ Hits         9340    14158     +4818     
+ Misses      14450     9807     -4643     
- Partials     1358     1566      +208     
Flag Coverage Δ
bats 37.00% <ø> (-0.14%) ⬇️
unit-linux 54.52% <ø> (?)
unit-windows 50.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/utils.go 35.60% <ø> (ø)

... and 87 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc changed the title cscli: add 10e9 to metric units cscli: add 1e9 to metric units Jun 2, 2023
@mmetc mmetc changed the title cscli: add 1e9 to metric units cscli: add G (1e9) suffix to metric units Jun 2, 2023
@mmetc mmetc added the kind/bug Something isn't working label Jun 2, 2023
@mmetc mmetc added this to the 1.5.3 milestone Jun 2, 2023
@mmetc mmetc merged commit 228e4f9 into master Jun 2, 2023
@mmetc mmetc deleted the metrics-giga branch June 2, 2023 12:38
mmetc added a commit that referenced this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant