don't pre-create log files (not required anymore)

[mmetc]

The lumberjack package fixed the issue in natefinch/lumberjack#83 (tested with umask 002) and this code is now redundant since we updated the dependency to v2.2.1.

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[mmetc]

ref. crowdsecurity/cs-firewall-bouncer#294

[codecov]

Codecov Report

Merging #2267 (360b62a) into master (0191faf) will increase coverage by 4.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
+ Coverage   51.53%   55.63%   +4.09%     
==========================================
  Files         182      182              
  Lines       25541    25527      -14     
==========================================
+ Hits        13163    14202    +1039     
+ Misses      10846     9761    -1085     
- Partials     1532     1564      +32     

Flag	Coverage Δ
bats	37.25% <100.00%> (+<0.01%)	⬆️
unit-linux	54.47% <100.00%> (?)
unit-windows	50.96% <50.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/apiserver/apiserver.go	65.10% <100.00%> (-0.57%)	⬇️
pkg/types/utils.go	57.44% <100.00%> (-2.29%)	⬇️

... and 31 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LaurenceJJones]

Should we also catch the crowdsec_api.log also?

crowdsec/pkg/apiserver/apiserver.go

Lines 168 to 173 in 2a8e97d

	_, err := os.Stat(logFile)
	// create file if not exists, purposefully ignore errors
	if os.IsNotExist(err) {
	file, _ := os.OpenFile(logFile, os.O_RDWR|os.O_CREATE, 0600)
	file.Close()
	}