Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor refactor to pkg/types, cscli machines #2270

Merged
merged 2 commits into from
Jun 8, 2023
Merged

minor refactor to pkg/types, cscli machines #2270

merged 2 commits into from
Jun 8, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 6, 2023

trim down pkg/types by moving away functions that are only used in one package

@mmetc mmetc added this to the 1.5.3 milestone Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #2270 (e5640b6) into master (3cc6b2c) will decrease coverage by 0.01%.
The diff coverage is 31.86%.

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
- Coverage   55.62%   55.62%   -0.01%     
==========================================
  Files         182      183       +1     
  Lines       25551    25552       +1     
==========================================
  Hits        14213    14213              
- Misses       9779     9786       +7     
+ Partials     1559     1553       -6     
Flag Coverage Δ
bats 37.28% <31.86%> (+0.01%) ⬆️
unit-linux 54.69% <ø> (+0.12%) ⬆️
unit-windows 51.09% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/crowdsec-cli/config_restore.go 35.37% <0.00%> (ø)
cmd/crowdsec-cli/utils.go 35.60% <0.00%> (ø)
pkg/types/utils.go 72.63% <ø> (+12.90%) ⬆️
cmd/crowdsec-cli/config_backup.go 51.45% <14.28%> (ø)
cmd/crowdsec-cli/copyfile.go 33.33% <33.33%> (ø)
cmd/crowdsec-cli/machines.go 52.64% <38.46%> (-0.13%) ⬇️
cmd/crowdsec-cli/machines_table.go 68.42% <40.00%> (-11.58%) ⬇️
cmd/crowdsec-cli/support.go 58.65% <100.00%> (+0.40%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc requested a review from sabban June 8, 2023 12:21
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 25bb23d into master Jun 8, 2023
@mmetc mmetc deleted the simple branch June 8, 2023 13:08
mmetc added a commit that referenced this pull request Jun 9, 2023
* cleanup: separate ui and logic
* trim some code from pkg/types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants