-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spellcheck/style leakybucket readme #2294
Conversation
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
- Coverage 55.73% 55.63% -0.10%
==========================================
Files 183 183
Lines 25523 25523
==========================================
- Hits 14224 14199 -25
- Misses 9744 9778 +34
+ Partials 1555 1546 -9
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One assertion isn't true anymore
@@ -126,17 +133,17 @@ leakspeed and an infinite capacity [capacity set to -1 for now]. | |||
|
|||
[This is not dry enough to have many details here, but:] | |||
|
|||
The bucket code is triggered by `InfiniBucketify` in main.go. | |||
There's one struct called buckets which is for now a | |||
The bucket code is triggered by `InfiniBucketify` in `main.go`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true anymore, it's run from runPour
in pour.go
. So I suggest
The bucket code is triggered by runPour
in pour.go
, by calling the leaky.PourItemToHolders
function.
No description provided.