Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spellcheck/style leakybucket readme #2294

Merged
merged 1 commit into from
Jun 21, 2023
Merged

spellcheck/style leakybucket readme #2294

merged 1 commit into from
Jun 21, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 21, 2023

No description provided.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #2294 (ca45e4c) into master (062f71f) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
- Coverage   55.73%   55.63%   -0.10%     
==========================================
  Files         183      183              
  Lines       25523    25523              
==========================================
- Hits        14224    14199      -25     
- Misses       9744     9778      +34     
+ Partials     1555     1546       -9     
Flag Coverage Δ
bats 37.25% <ø> (-0.10%) ⬇️
unit-linux 54.70% <ø> (+0.06%) ⬆️
unit-windows 51.21% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc added this to the 1.5.3 milestone Jun 21, 2023
@mmetc mmetc marked this pull request as ready for review June 21, 2023 07:51
@mmetc mmetc requested a review from sabban June 21, 2023 08:19
@mmetc mmetc merged commit da6106b into master Jun 21, 2023
@mmetc mmetc deleted the bucket-readme branch June 21, 2023 09:47
@mmetc mmetc requested a review from seemanne June 21, 2023 09:47
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One assertion isn't true anymore

@@ -126,17 +133,17 @@ leakspeed and an infinite capacity [capacity set to -1 for now].

[This is not dry enough to have many details here, but:]

The bucket code is triggered by `InfiniBucketify` in main.go.
There's one struct called buckets which is for now a
The bucket code is triggered by `InfiniBucketify` in `main.go`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true anymore, it's run from runPour in pour.go. So I suggest

The bucket code is triggered by runPour in pour.go, by calling the leaky.PourItemToHolders function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants