Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename metabase APIClient to avoid confusion #2305

Merged
merged 1 commit into from
Jun 27, 2023
Merged

rename metabase APIClient to avoid confusion #2305

merged 1 commit into from
Jun 27, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 23, 2023

No description provided.

@mmetc mmetc added this to the 1.5.3 milestone Jun 23, 2023
@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #2305 (5d5f0cf) into master (aeca8f4) will decrease coverage by 4.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2305      +/-   ##
==========================================
- Coverage   55.73%   51.68%   -4.06%     
==========================================
  Files         185      185              
  Lines       25703    25703              
==========================================
- Hits        14326    13284    -1042     
- Misses       9823    10901    +1078     
+ Partials     1554     1518      -36     
Flag Coverage Δ
bats 37.06% <0.00%> (+0.02%) ⬆️
unit-linux ?
unit-windows 51.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/metabase/api.go 0.00% <0.00%> (ø)
pkg/metabase/database.go 0.00% <0.00%> (ø)
pkg/metabase/metabase.go 0.00% <0.00%> (ø)

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mmetc mmetc merged commit 893394e into master Jun 27, 2023
@mmetc mmetc deleted the mbclient branch June 27, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants