-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[postoverflow] dump after postoverflow so we can test within hubtest #2511
[postoverflow] dump after postoverflow so we can test within hubtest #2511
Conversation
@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind enhancement |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2511 +/- ##
=======================================
Coverage 56.84% 56.84%
=======================================
Files 190 190
Lines 26156 26158 +2
=======================================
+ Hits 14868 14870 +2
Misses 9732 9732
Partials 1556 1556
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is the first PR to allow some sort of postoverflow hubtests
Currently when the event is passed into
bucketOverflows
it is before the postoverflow meaning if the event does pass the postoverflow whitelist none of the properties are set within the dump file. Setting the append after postoverflows means hubtest can ingest this and test if the scenario is whitelist via expr