Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka acquisition: warn if no consumer group id and allow to read from a specific partition #2612

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

blotus
Copy link
Member

@blotus blotus commented Nov 22, 2023

  • Update kafka-go to latest release
  • Warn if no group_id is set in the configuration
  • Allow to read from a specific partition to help debugging in some cases

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Nov 22, 2023

/kind enhancement
/area agent

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (92f923c) 56.94% compared to head (2bd88a5) 56.96%.

Files Patch % Lines
pkg/acquisition/modules/kafka/kafka.go 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
+ Coverage   56.94%   56.96%   +0.01%     
==========================================
  Files         195      195              
  Lines       26675    26682       +7     
==========================================
+ Hits        15191    15200       +9     
+ Misses       9901     9899       -2     
  Partials     1583     1583              
Flag Coverage Δ
bats 37.78% <0.00%> (-0.02%) ⬇️
unit-linux 55.42% <62.50%> (+0.01%) ⬆️
unit-windows 51.83% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit ec53c67 into master Nov 23, 2023
14 checks passed
@blotus blotus deleted the kafka-warn-no-consumer-group branch November 23, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants