Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metabase] QOL Changes and chown wal files #2627

Merged

Conversation

LaurenceJJones
Copy link
Contributor

Fix #2624

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/area agent
/kind fix

@LaurenceJJones LaurenceJJones changed the title Add detection sqlie wal for dashboard chown Add detection sqlite wal for dashboard chown Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (7e5ab34) 58.22% compared to head (7887449) 58.20%.

Files Patch % Lines
cmd/crowdsec-cli/dashboard.go 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
- Coverage   58.22%   58.20%   -0.03%     
==========================================
  Files         201      201              
  Lines       27048    27051       +3     
==========================================
- Hits        15750    15744       -6     
- Misses       9753     9761       +8     
- Partials     1545     1546       +1     
Flag Coverage Δ
bats 38.30% <0.00%> (-0.10%) ⬇️
unit-linux 55.24% <ø> (+0.01%) ⬆️
unit-windows 51.52% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LaurenceJJones LaurenceJJones changed the title Add detection sqlite wal for dashboard chown [Metabase] QOL Changes and chown wal files Nov 30, 2023
@LaurenceJJones LaurenceJJones merged commit ed3d501 into crowdsecurity:master Dec 4, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metabase] WAL mode permissions
4 participants